From 734d6306a261d209579ae473e5a004b65f55f6e2 Mon Sep 17 00:00:00 2001 From: David Wells Date: Mon, 3 Sep 2018 10:43:00 -0400 Subject: Fix two dependencies with silo. (#9153) 1. I presently get errors of the sort ==> Error: KeyError: 'No spec with name mpi in silo@4.10.2%gcc@8.1.0+fortran+mpi [...] $HOME/spack/var/spack/repos/builtin/packages/silo/package.py:84, in configure_args: 81 'FCFLAGS={0}'.format(self.compiler.pic_flag)] 82 83 if '+mpi' in self.spec: >> 84 config_args.append('CC=%s' % self.spec['mpi'].mpicc) 85 config_args.append('CXX=%s' % self.spec['mpi'].mpicxx) 86 config_args.append('FC=%s' % self.spec['mpi'].mpifc) without the extra explicit MPI dependency. 2. Silo uses zlib, so we should explicitly depend on it. --- var/spack/repos/builtin/packages/silo/package.py | 2 ++ 1 file changed, 2 insertions(+) (limited to 'var') diff --git a/var/spack/repos/builtin/packages/silo/package.py b/var/spack/repos/builtin/packages/silo/package.py index d236a661f2..86c19e77f9 100644 --- a/var/spack/repos/builtin/packages/silo/package.py +++ b/var/spack/repos/builtin/packages/silo/package.py @@ -48,8 +48,10 @@ class Silo(AutotoolsPackage): description='Compile with MPI Compatibility') depends_on('hdf5~mpi', when='~mpi') + depends_on('mpi', when='+mpi') depends_on('hdf5+mpi', when='+mpi') depends_on('qt', when='+silex') + depends_on('zlib') patch('remove-mpiposix.patch', when='@4.8:4.10.2') -- cgit v1.2.3-70-g09d2