From a93a6136682debfd58d295e3035ad2c6d142bda1 Mon Sep 17 00:00:00 2001 From: Massimiliano Culpo Date: Mon, 2 Dec 2019 23:05:02 +0100 Subject: Speedup environment activation (#13557) * Add a transaction around repeated calls to `spec.prefix` in the activation process * cache the computation of home in the python package to speed up setting deps * ensure that module-scope variables are only set *once* per module --- var/spack/repos/builtin/packages/python/package.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'var') diff --git a/var/spack/repos/builtin/packages/python/package.py b/var/spack/repos/builtin/packages/python/package.py index 15901872e9..a92d1c6c79 100644 --- a/var/spack/repos/builtin/packages/python/package.py +++ b/var/spack/repos/builtin/packages/python/package.py @@ -163,6 +163,9 @@ class Python(AutotoolsPackage): _DISTUTIL_CACHE_FILENAME = 'sysconfig.json' _distutil_vars = None + # Used to cache home locations, since computing them might be expensive + _homes = {} + # An in-source build with --enable-optimizations fails for python@3.X build_directory = 'spack-build' @@ -622,8 +625,11 @@ class Python(AutotoolsPackage): ``packages.yaml`` unknowingly. Query the python executable to determine exactly where it is installed.""" - prefix = self.get_config_var('prefix') - return Prefix(prefix) + dag_hash = self.spec.dag_hash() + if dag_hash not in self._homes: + prefix = self.get_config_var('prefix') + self._homes[dag_hash] = Prefix(prefix) + return self._homes[dag_hash] @property def libs(self): -- cgit v1.2.3-70-g09d2