From b014ffcd3dd65e57a2c2871aea19b45bddd68155 Mon Sep 17 00:00:00 2001 From: ketsubouchi Date: Thu, 10 Sep 2020 11:03:59 +0900 Subject: darshan-util: remove return(-1) from void function (#18504) * darshan-util: remove return(-1) from void function * Update var/spack/repos/builtin/packages/darshan-util/package.py Co-authored-by: Adam J. Stewart * Update var/spack/repos/builtin/packages/darshan-util/package.py Co-authored-by: Adam J. Stewart Co-authored-by: Adam J. Stewart --- var/spack/repos/builtin/packages/darshan-util/package.py | 2 ++ var/spack/repos/builtin/packages/darshan-util/retvoid.patch | 12 ++++++++++++ 2 files changed, 14 insertions(+) create mode 100644 var/spack/repos/builtin/packages/darshan-util/retvoid.patch (limited to 'var') diff --git a/var/spack/repos/builtin/packages/darshan-util/package.py b/var/spack/repos/builtin/packages/darshan-util/package.py index af5502a7fb..abd194e027 100644 --- a/var/spack/repos/builtin/packages/darshan-util/package.py +++ b/var/spack/repos/builtin/packages/darshan-util/package.py @@ -31,6 +31,8 @@ class DarshanUtil(Package): depends_on('zlib') depends_on('bzip2', when="+bzip2", type=("build", "link", "run")) + patch('retvoid.patch', when='@3.2.0:3.2.1') + def install(self, spec, prefix): options = ['CC=%s' % self.compiler.cc, diff --git a/var/spack/repos/builtin/packages/darshan-util/retvoid.patch b/var/spack/repos/builtin/packages/darshan-util/retvoid.patch new file mode 100644 index 0000000000..63175b61d7 --- /dev/null +++ b/var/spack/repos/builtin/packages/darshan-util/retvoid.patch @@ -0,0 +1,12 @@ +diff -u -r -N a/darshan-util/darshan-logutils.c b/darshan-util/darshan-logutils.c +--- a/darshan-util/darshan-logutils.c 2020-09-04 15:02:21.000000000 +0900 ++++ b/darshan-util/darshan-logutils.c 2020-09-04 15:07:44.000000000 +0900 +@@ -1915,7 +1915,7 @@ + if(ret < 0) + { + darshan_log_close(fd); +- return(-1); ++ return; + } + + int num = HASH_CNT(hlink, name_hash); -- cgit v1.2.3-70-g09d2