From b667be470e6f3f598c72e1107b07057e8529c86c Mon Sep 17 00:00:00 2001 From: Harmen Stoppels Date: Fri, 8 Apr 2022 09:28:31 +0200 Subject: zstd: improve %nvhpc conflict (#29867) --- var/spack/repos/builtin/packages/zstd/package.py | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) (limited to 'var') diff --git a/var/spack/repos/builtin/packages/zstd/package.py b/var/spack/repos/builtin/packages/zstd/package.py index e1daec856b..9b82773eb2 100644 --- a/var/spack/repos/builtin/packages/zstd/package.py +++ b/var/spack/repos/builtin/packages/zstd/package.py @@ -38,12 +38,22 @@ class Zstd(MakefilePackage): depends_on('lz4', when='+programs') depends_on('xz', when='+programs') - conflicts('%nvhpc') + # +programs builds vendored xxhash, which uses unsupported builtins + # (last tested: nvhpc@22.3) + conflicts('+programs %nvhpc') def _make(self, *args, **kwargs): # PREFIX must be defined on macOS even when building the library, since # it gets hardcoded into the library's install_path - make('VERBOSE=1', 'PREFIX=' + self.prefix, '-C', *args, **kwargs) + def_args = ['VERBOSE=1', 'PREFIX=' + self.prefix] + + # Tested %nvhpc@22.3. No support for -MP + if '%nvhpc' in self.spec: + def_args.append('DEPFLAGS=-MT $@ -MMD -MF') + + def_args.append('-C') + def_args.extend(args) + make(*def_args, **kwargs) def build(self, spec, prefix): self._make('lib') -- cgit v1.2.3-60-g2f50