From c126c5553c81c1ab150b4ccefd6cba7507f20530 Mon Sep 17 00:00:00 2001 From: George Hartzell Date: Mon, 31 Jul 2017 09:17:04 -0700 Subject: zsh: add variant that skips tcsetpgrp test (#4923) zsh's configure script fails if there's it tries to test for terminal functionality if there's not a terminal (e.g. in a Jenkins build). The configure script has a switch that asserts that tcsetpgrp works and thereby avoids running that test. This commit adds a variant that invokes that switch, defaulting to True. --- var/spack/repos/builtin/packages/zsh/package.py | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'var') diff --git a/var/spack/repos/builtin/packages/zsh/package.py b/var/spack/repos/builtin/packages/zsh/package.py index 7a298d16b5..7225418363 100644 --- a/var/spack/repos/builtin/packages/zsh/package.py +++ b/var/spack/repos/builtin/packages/zsh/package.py @@ -37,5 +37,21 @@ class Zsh(AutotoolsPackage): version('5.3.1', checksum='d583fbca0c2410bf9542ce8a651c26ca') version('5.1.1', checksum='8ba28a9ef82e40c3a271602f18343b2f') + # Testing for terminal related things causes failures in e.g. Jenkins. + # See e.g. https://www.zsh.org/mla/users/2003/msg00845.html, + # although the name of the option has evolved since then. + variant('skip-tcsetpgrp-test', default=True, + description="Skip configure's tcsetpgrp test") + depends_on("pcre") depends_on("ncurses") + + def configure_args(self): + if '+skip-tcsetpgrp-test' in self.spec: + # assert that we have a functional tcsetpgrp + args = ['--with-tcsetpgrp'] + else: + # let configure run it's test and see what's what + args = [] + + return args -- cgit v1.2.3-70-g09d2