From ed8fe68cf2162a8a871e639035093722bcd2cb84 Mon Sep 17 00:00:00 2001 From: Massimiliano Culpo Date: Tue, 12 Jan 2021 12:35:48 +0100 Subject: concretizer: dependency conditions cannot hold if package is external fixes #20736 Before this one line fix we were erroneously deducing that dependency conditions hold even if a package was external. This may result in answer sets that contain imposed conditions on a node without the node being present in the DAG, hence #20736. --- .../builtin.mock/packages/external-buildable-with-variant/package.py | 3 +++ 1 file changed, 3 insertions(+) (limited to 'var') diff --git a/var/spack/repos/builtin.mock/packages/external-buildable-with-variant/package.py b/var/spack/repos/builtin.mock/packages/external-buildable-with-variant/package.py index e9382cdbff..b62fb062bf 100644 --- a/var/spack/repos/builtin.mock/packages/external-buildable-with-variant/package.py +++ b/var/spack/repos/builtin.mock/packages/external-buildable-with-variant/package.py @@ -11,5 +11,8 @@ class ExternalBuildableWithVariant(Package): url = "http://somewhere.com/module-1.0.tar.gz" version('1.0', '1234567890abcdef1234567890abcdef') + version('0.9', '1234567890abcdef1234567890abcdef') variant('baz', default=False, description='nope') + + depends_on('c@1.0', when='@0.9') -- cgit v1.2.3-70-g09d2