From f171d7ed15e88ff6c5265fca4ea6ed2f6a5023bc Mon Sep 17 00:00:00 2001 From: MikeG Date: Fri, 14 Apr 2023 04:22:59 +0200 Subject: py-dask-mpi: remove jupyter-server-proxy (#36680) * py-dask-mpi: remove jupyter-server-proxy This dependency isn't a 'hard' one; it optionally simplifies getting access to the web consoles. See: https://github.com/dask/dask-mpi/pull/102 * Add patch to remove unnecessary dependency * review comments * pass formatting --- var/spack/repos/builtin/packages/py-dask-mpi/package.py | 5 ++++- .../packages/py-dask-mpi/remove-dependency-jupyter-proxy.patch | 9 +++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 var/spack/repos/builtin/packages/py-dask-mpi/remove-dependency-jupyter-proxy.patch (limited to 'var') diff --git a/var/spack/repos/builtin/packages/py-dask-mpi/package.py b/var/spack/repos/builtin/packages/py-dask-mpi/package.py index 9f0a6f7381..fb2c6a0e5e 100644 --- a/var/spack/repos/builtin/packages/py-dask-mpi/package.py +++ b/var/spack/repos/builtin/packages/py-dask-mpi/package.py @@ -23,6 +23,9 @@ class PyDaskMpi(PythonPackage): depends_on("py-dask@2.2:", when="@:2.21.0", type=("build", "run")) depends_on("py-dask@2.19:", when="@2022.4.0:", type=("build", "run")) depends_on("py-distributed@2.19:", when="@2022.4.0:", type=("build", "run")) - depends_on("py-jupyter-server-proxy", type=("build", "run")) depends_on("py-mpi4py", type=("build", "run")) depends_on("py-mpi4py@3.0.3:", when="@2022.4.0:", type=("build", "run")) + + # jupyter-server-proxy is not a needed dependency; https://github.com/dask/dask-mpi/pull/102 + # this significantly reduces the dependency tree of py-dask-mpi + patch("remove-dependency-jupyter-proxy.patch", when="@:2022.4.0") diff --git a/var/spack/repos/builtin/packages/py-dask-mpi/remove-dependency-jupyter-proxy.patch b/var/spack/repos/builtin/packages/py-dask-mpi/remove-dependency-jupyter-proxy.patch new file mode 100644 index 0000000000..61116f39e4 --- /dev/null +++ b/var/spack/repos/builtin/packages/py-dask-mpi/remove-dependency-jupyter-proxy.patch @@ -0,0 +1,9 @@ +diff --git a/environment.yml b/environment.yml +index 5747157..a552b81 100644 +--- a/environment.yml ++++ b/environment.yml +@@ -3,4 +3,3 @@ dependencies: + - dask>=2.19 + - distributed>=2.19 + - mpi4py>=3.0.3 +- - jupyter-server-proxy -- cgit v1.2.3-60-g2f50