summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHarmen Stoppels <harmenstoppels@gmail.com>2021-12-21 18:41:12 +0100
committerMassimiliano Culpo <massimiliano.culpo@gmail.com>2021-12-23 16:02:09 +0100
commit5daf023aecf3d72943cff0a010dfafd95edfdf3b (patch)
treeb17b53d667f0106d8060be30d44235de46170559
parent87abda4cdd689bf9dff66960558dc63268794d87 (diff)
downloadspack-5daf023aecf3d72943cff0a010dfafd95edfdf3b.tar.gz
spack-5daf023aecf3d72943cff0a010dfafd95edfdf3b.tar.bz2
spack-5daf023aecf3d72943cff0a010dfafd95edfdf3b.tar.xz
spack-5daf023aecf3d72943cff0a010dfafd95edfdf3b.zip
Regenerate views when specs already installed (#28113)
With this commit: ``` $ spack env activate --temp $ spack install zlib ==> All of the packages are already installed ==> Updating view at /tmp/spack-faiirgmt/.spack-env/view $ spack install zlib ==> All of the packages are already installed ``` Before this PR: ``` $ spack env activate --temp $ spack install zlib ==> All of the packages are already installed $ spack install zlib ==> All of the packages are already installed ``` No view was generated
-rw-r--r--lib/spack/spack/environment/environment.py6
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/spack/spack/environment/environment.py b/lib/spack/spack/environment/environment.py
index a6be5d1c50..3114f55638 100644
--- a/lib/spack/spack/environment/environment.py
+++ b/lib/spack/spack/environment/environment.py
@@ -1500,10 +1500,8 @@ class Environment(object):
if not specs_to_install:
tty.msg('All of the packages are already installed')
- return
-
- tty.debug('Processing {0} uninstalled specs'.format(
- len(specs_to_install)))
+ else:
+ tty.debug('Processing {0} uninstalled specs'.format(len(specs_to_install)))
install_args['overwrite'] = install_args.get(
'overwrite', []) + self._get_overwrite_specs()