diff options
| author | Max Rees <maxcrees@me.com> | 2019-06-13 23:19:54 -0400 |
|---|---|---|
| committer | Natanael Copa <ncopa@alpinelinux.org> | 2019-06-20 11:36:40 +0200 |
| commit | 297de93aef3110f6ced8926e64e4204692b3b74e (patch) | |
| tree | 207c0fd0cb3ba59b39d5d7c84a8230b9c02569c4 /abuild-fetch.c | |
| parent | 0b3f983772e6c6fda103252bc67a477ea39d61c9 (diff) | |
| download | abuild-297de93aef3110f6ced8926e64e4204692b3b74e.tar.gz abuild-297de93aef3110f6ced8926e64e4204692b3b74e.tar.bz2 abuild-297de93aef3110f6ced8926e64e4204692b3b74e.tar.xz abuild-297de93aef3110f6ced8926e64e4204692b3b74e.zip | |
abuild-sudo: don't allow --keys-dir
Not allowing --allow-untrusted is obviously a good idea, but it can be
trivially bypassed if --keys-dir is allowed:
$ abuild-apk add foo-1-r0.apk
ERROR: foo-1-r0.apk: UNTRUSTED signature
$ abuild-apk --allow-untrusted add foo-1-r0.apk
abuild-apk: --allow-untrusted: not allowed option
$ cp -rp /etc/apk/keys /tmp/keys
$ cp untrusted.pub /tmp/keys
$ abuild-apk --keys-dir /tmp/keys add foo-1-r0.apk
(1/1) Installing foo (1-r0)
OK: 4319 MiB in 806 packages
If both --allow-untrusted and --keys-dir are not allowed, then it should
no longer be possible for an unprivileged member of the abuild group to
add an untrusted package.
$ abuild-apk --keys-dir /tmp/keys add foo-1-r0.apk
abuild-apk: --keys-dir: not allowed option
Diffstat (limited to 'abuild-fetch.c')
0 files changed, 0 insertions, 0 deletions