abuild: check sanity of install scripts

we check early that suffix is valid and that we have a matching
pkgname or subpackage

1 files changed, 10 insertions, 1 deletions

diff --git a/abuild.in b/abuild.in
index 439b4f5..59d622b 100755
--- a/abuild.in
+++ b/abuild.in
@@ -96,7 +96,7 @@ die() {
 
 # check if apkbuild is basicly sane
 sanitycheck() {
-	local i suggestion
+	local i= j= suggestion=
 	msg "Checking sanity of $APKBUILD..."
 	[ -z "$pkgname" ] && die "Missing pkgname in APKBUILD"
 	[ -z "${pkgname##* *}" ] && die "pkgname contains spaces"
@@ -121,6 +121,15 @@ sanitycheck() {
 	[ -z "$CHOST" ] && die "Please set CHOST in /etc/abuild.conf"
 
 	for i in $install; do
+		local n=${i%.*}
+		local suff=${i#*.}
+		case "$suff" in
+		pre-install|post-install|pre-upgrade|post-upgrade|pre-deinstall|post-deinstall);;
+		*) die "$i: unknown install script suffix"
+		esac
+		if ! subpackages_has "$n" && [ "$n" != "$pkgname" ]; then
+			die "$i: install script does not match pkgname or any subpackages"
+		fi
 		[ -e "$startdir/$i" ] || die "install script $startdir/$i is missing"
 	done