Age | Commit message (Collapse) | Author | Files | Lines |
|
- do not overwrite variables
srcdir is very important for abuild operation
- quoted various paths
- use a sub-shell to contain directory changing
Resolves alpinelinux/abuild#58
|
|
|
|
Some projects might leave files which are not writable for the current
user. The cleanup process then fails and leaves files / directories
behind.
This can easily be fixed by making everything writable before removing
the files.
Add the option 'chmod-clean' which does just that.
|
|
|
|
|
|
- Also check for static archives and warn on lack of static subpackage
|
|
Since `$builddir` is officially supported and abuild automatically cd's to `$builddir`, it does not need to be part of the template anymore.
|
|
This reverts commit 57f2830739e31f9c73d2edaf5103502fbdae6822.
https://github.com/alpinelinux/aports/pull/7203 fixes the original problem
|
|
directory change
|
|
|
|
|
|
From what I could find, it was changed to -musleabihf during the Alpine
3.6 release cycle but this function was never updated to reflect that
|
|
Apparently there are many packages that does soemthing like:
subpackages="$pkgname-foo:_foo"
_foo() {
depends="$depends something-else"
}
and thus depend on the previous behavior. We need to revert and plan
this better.
This reverts commit 8fbbffd201a28a06804c7f6d3a2b5cd948c6ce07.
|
|
|
|
Other subpackage such as -dev, -doc and even -openrc allow adjusting
depends of the subpackage through such a variable. This is, for
instance, useful to remove a dependency of the origin package from the
-libs subpackage.
While at it document it in APKBUILD(5).
|
|
|
|
(returnes unknown)
|
|
|
|
In some cases, a simple rm -rf is not sufficent to clean srcdir.
One such case is the new go module system, that marks everything as
read-only - thus only letting root rm -rf it without a chmod.
There is a command intended to clean them - `go clean -modcache`.
However, for that to work, GOPATH must be defined and existent.
Running chmod for all srcdir cleanups makes no sense, nor does enforcing
root, or putting global overrides just for go.
This patch allows overriding what happens on `cleanup srcdir`, by
overriding cleanup_srcdir, and allows the use of default_cleanup_srcdir.
In our go example, it might be used as such:
cleanup_srcdir() {
go clean -modcache
default_cleanup_srcdir
}
|
|
Avoid DRY issues, and increase consistency.
|
|
make sure that subpackages does not inherit main package's depends.
|
|
replace litteral version string with $pkgver in source url
|
|
we need to check if a given module currently is a part of core. Modules
which have a first_release may have been removed later, for example
Module::Build.
|
|
the generation of Makefile is comparable with running configure, which
we normally do in the build() function, not in prepare.
also fix some whitespace damamge.
|
|
|
|
|
|
|
|
|
|
|
|
This prevents clang from issuing a warning here.
|
|
|
|
Link against the same libs as abuild-tar and fix the order of the CC
arguments.
|
|
|
|
|
|
In some cases (ie drone ci) there is no tty available but its still
possible to display colors in the webui.
|
|
Fix issue when two -dev packages provides same pkg-config wil but with
different versions. For example libressl-dev and openssl-dev both ships
libssl.pc and libcrypto.pc, which resulted in automatic provides of
pc:libssl and pc:libcrypto.
apk would end up picking libressl-dev over openssl-dev for packages that
had automatic pc:libssl depends (for example libssl2-dev), when
openssl-dev was the one that was used during build.
To fix this we add support for a pcprefix so we can set
pcprefix="libressl:" in libressl APKBUILD which makes libressl-dev
provide pc:libressl:libssl. This is similar to what we do with
sonameprefix.
We do not yet automatically detect when the prefixed variant should be
used so for now we will have to explicitly add libressl-dev.
ref #9959
|
|
|
|
|
|
|
|
openssl binary may be missing while migrating system from libressl to
openssl. Make sure we can always sign the backage if either is there.
|
|
|
|
packages should never depend on themselves which does not make sense.
This may happen if main package depends on a subpackage, then the
subpackages will inherit the global depends and the subpackage ends up
depend on itself.
Fix abuild to avoid this.
|
|
|
|
The 'Compressing data' step takes a significant amount of time when
packaging software with huge binaries, like Kubernetes. This can
certainly be shortened using multithreaded compression, like 'pigz'.
|
|
|
|
Symbolic links might point to files outside of the chroot and
thus might delete files outside the chroot. This allows deletion
of arbitrary directories on the host from a malicious APKBUILD.
Following hard links shouldn't be a problem since hard links (usually)
cannot refer to directories and since remove(3) removes the link, not
the file it points to it shouldn't cause a problem.
I noticed this because alpine-baselayout creates /var/run as a symlink
to /run. Therefore causing /run to be deleted on the host when using
abuild-rmtemp which in turn causes a bunch of software to no longer
function properly (including OpenRC).
|
|
|
|
So we make sure chdir $builddir happens when it should.
|
|
Only run check in fakeroot if options="checkroot" is set. This makes
options="!checkroot" the default.
I expect most checks work as non-root, and if a testsuite requires root,
it will likely fail in fakeroot too. Fakeroot has also shown lower
performance for parallel builds.
|
|
instead of printing abuild version, print package version. This is to
avoid confuse the abuild version with the package version.
|