diff options
| author | Timo Teräs <timo.teras@iki.fi> | 2020-08-24 13:35:36 +0300 |
|---|---|---|
| committer | Timo Teräs <timo.teras@iki.fi> | 2020-08-24 13:35:36 +0300 |
| commit | edb45ae46449ddabcac3dea6b3f42c6cec01510a (patch) | |
| tree | a27a046df30e4ead8f36c559dabdecb2fa1d7ea5 /src/app_fix.c | |
| parent | 82de29cf7bad3d9cbb0aeb4dbe756ad2bde73eb3 (diff) | |
| download | apk-tools-edb45ae46449ddabcac3dea6b3f42c6cec01510a.tar.gz apk-tools-edb45ae46449ddabcac3dea6b3f42c6cec01510a.tar.bz2 apk-tools-edb45ae46449ddabcac3dea6b3f42c6cec01510a.tar.xz apk-tools-edb45ae46449ddabcac3dea6b3f42c6cec01510a.zip | |
enforce options definitions to bind the enum and the descriptor
This uses some macro trickery to make sure that there's one-to-one
mapping with the option index enum and the descriptor. The down
side is that enum's are generated via #define's and editors might
not pick them up for auto completion, but the benefits are more:
it's no longer possible have mismatching enum value and descriptor
index, and the amount of source code lines is less.
Diffstat (limited to 'src/app_fix.c')
| -rw-r--r-- | src/app_fix.c | 23 |
1 files changed, 8 insertions, 15 deletions
diff --git a/src/app_fix.c b/src/app_fix.c index 43e6f7e..ccd1e3c 100644 --- a/src/app_fix.c +++ b/src/app_fix.c @@ -22,21 +22,14 @@ struct fix_ctx { int errors; }; -enum { - OPT_FIX_depends, - OPT_FIX_directory_permissions, - OPT_FIX_reinstall, - OPT_FIX_upgrade, - OPT_FIX_xattr, -}; - -static const char option_desc[] = - APK_OPTAPPLET - APK_OPT2n("depends", "d") - APK_OPT1n("directory-permissions") - APK_OPT2n("reinstall", "r") - APK_OPT2n("upgrade", "u") - APK_OPT2n("xattr", "x"); +#define FIX_OPTIONS(OPT) \ + OPT(OPT_FIX_depends, APK_OPT_SH("d") "depends") \ + OPT(OPT_FIX_directory_permissions, "directory-permissions") \ + OPT(OPT_FIX_reinstall, APK_OPT_SH("r") "reinstall") \ + OPT(OPT_FIX_upgrade, APK_OPT_SH("u") "upgrade") \ + OPT(OPT_FIX_xattr, APK_OPT_SH("x") "xattr") + +APK_OPT_APPLET(option_desc, FIX_OPTIONS); static int option_parse_applet(void *pctx, struct apk_db_options *dbopts, int opt, const char *optarg) { |