Initial commit of some stuff written so far. Still in state of flux. Expect

breakage and major changes.

1 files changed, 802 insertions, 0 deletions

diff --git a/src/database.c b/src/database.c
new file mode 100644
index 0000000..f98be64
--- /dev/null
+++ b/src/database.c
@@ -0,0 +1,802 @@
+/* database.c - Alpine Package Keeper (APK)
+ *
+ * Copyright (C) 2005-2008 Natanael Copa <n@tanael.org>
+ * Copyright (C) 2008 Timo Teräs <timo.teras@iki.fi>
+ * All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify it 
+ * under the terms of the GNU General Public License version 2 as published
+ * by the Free Software Foundation. See http://www.gnu.org/ for details.
+ */
+
+#include <errno.h>
+#include <stdio.h>
+#include <fcntl.h>
+#include <unistd.h>
+#include <malloc.h>
+#include <string.h>
+
+#include "apk_defines.h"
+#include "apk_package.h"
+#include "apk_database.h"
+#include "apk_state.h"
+
+struct install_ctx {
+	struct apk_database *db;
+	struct apk_package *pkg;
+
+	int script;
+	struct apk_db_dir *dircache;
+	struct hlist_node **file_dir_node;
+	struct hlist_node **file_pkg_node;
+};
+
+static apk_hash_key pkg_name_get_key(apk_hash_item item)
+{
+	return ((struct apk_name *) item)->name;
+}
+
+static const struct apk_hash_ops pkg_name_hash_ops = {
+	.node_offset = offsetof(struct apk_name, hash_node),
+	.get_key = pkg_name_get_key,
+	.hash_key = (apk_hash_f) apk_hash_string,
+	.compare = (apk_hash_compare_f) strcmp,
+	.delete_item = (apk_hash_delete_f) apk_name_free,
+};
+
+static apk_hash_key pkg_info_get_key(apk_hash_item item)
+{
+	return ((struct apk_package *) item)->csum;
+}
+
+static int cmpcsum(apk_hash_key a, apk_hash_key b)
+{
+	return memcmp(a, b, sizeof(csum_t));
+}
+
+static const struct apk_hash_ops pkg_info_hash_ops = {
+	.node_offset = offsetof(struct apk_package, hash_node),
+	.get_key = pkg_info_get_key,
+	.hash_key = (apk_hash_f) apk_hash_csum,
+	.compare = cmpcsum,
+	.delete_item = (apk_hash_delete_f) apk_pkg_free,
+};
+
+static apk_hash_key apk_db_dir_get_key(apk_hash_item item)
+{
+	return ((struct apk_db_dir *) item)->dirname;
+}
+
+static const struct apk_hash_ops dir_hash_ops = {
+	.node_offset = offsetof(struct apk_db_dir, hash_node),
+	.get_key = apk_db_dir_get_key,
+	.hash_key = (apk_hash_f) apk_hash_string,
+	.compare = (apk_hash_compare_f) strcmp,
+	.delete_item = (apk_hash_delete_f) free,
+};
+
+struct apk_name *apk_db_get_name(struct apk_database *db, const char *name)
+{
+	struct apk_name *pn;
+
+	pn = (struct apk_name *) apk_hash_get(&db->available.names, name);
+	if (pn != NULL)
+		return pn;
+
+	pn = calloc(1, sizeof(struct apk_name));
+	if (pn == NULL)
+		return NULL;
+
+	pn->name = strdup(name);
+	apk_hash_insert(&db->available.names, pn);
+
+	return pn;
+}
+
+void apk_name_free(struct apk_name *name)
+{
+	free(name->name);
+	free(name);
+}
+
+static struct apk_db_dir *apk_db_dir_ref(struct apk_database *db,
+					 struct apk_db_dir *dir,
+					 int create_dir)
+{
+	if (dir->refs == 0) {
+		if (dir->parent != NULL)
+			apk_db_dir_ref(db, dir->parent, create_dir);
+		db->installed.stats.dirs++;
+		if (create_dir)
+			mkdir(dir->dirname, dir->mode);
+	}
+	dir->refs++;
+
+	return dir;
+}
+
+static void apk_db_dir_unref(struct apk_database *db, struct apk_db_dir *dir)
+{
+	dir->refs--;
+	if (dir->refs > 0)
+		return;
+
+	db->installed.stats.dirs--;
+	rmdir(dir->dirname);
+
+	if (dir->parent != NULL)
+		apk_db_dir_unref(db, dir->parent);
+}
+
+static struct apk_db_dir *apk_db_dir_get(struct apk_database *db,
+					 apk_blob_t name)
+{
+	struct apk_db_dir *dir;
+	apk_blob_t bparent;
+	char *cstr;
+
+	if (name.ptr[name.len-1] == '/')
+		name.len--;
+
+	cstr = apk_blob_cstr(name);
+	dir = (struct apk_db_dir *) apk_hash_get(&db->installed.dirs, cstr);
+	free(cstr);
+	if (dir != NULL)
+		return dir;
+
+	dir = calloc(1, sizeof(*dir) + name.len + 1);
+	memcpy(dir->dirname, name.ptr, name.len);
+	dir->dirname[name.len] = 0;
+	apk_hash_insert(&db->installed.dirs, dir);
+
+	if (apk_blob_rsplit(name, '/', &bparent, NULL))
+		dir->parent = apk_db_dir_get(db, bparent);
+
+	return dir;
+}
+
+static struct apk_db_file *apk_db_file_new(struct apk_db_dir *dir,
+					   apk_blob_t name,
+					   struct hlist_node **after)
+{
+	struct apk_db_file *file;
+
+	file = calloc(1, sizeof(*file) + name.len + 1);
+	hlist_add_after(&file->dir_files_list, after);
+	file->dir = dir;
+	memcpy(file->filename, name.ptr, name.len);
+	file->filename[name.len] = 0;
+
+	return file;
+}
+
+static void apk_db_file_set_owner(struct apk_database *db,
+				  struct apk_db_file *file,
+				  struct apk_package *owner,
+				  int create_dir,
+				  struct hlist_node **after)
+{
+	if (file->owner != NULL)
+		return;
+
+	db->installed.stats.files++;
+	file->dir = apk_db_dir_ref(db, file->dir, create_dir);
+	file->owner = owner;
+	hlist_add_after(&file->pkg_files_list, after);
+}
+
+static struct apk_db_file *apk_db_file_get(struct apk_database *db,
+					   apk_blob_t name,
+					   struct install_ctx *ctx)
+{
+	struct apk_db_dir *dir;
+	struct apk_db_file *file;
+	struct hlist_node *cur;
+	apk_blob_t bdir, bfile;
+
+	if (!apk_blob_rsplit(name, '/', &bdir, &bfile))
+		return NULL;
+
+	dir = NULL;
+	if (ctx != NULL && ctx->dircache != NULL) {
+		dir = ctx->dircache;
+		if (strncmp(dir->dirname, bdir.ptr, bdir.len) != 0 ||
+		    dir->dirname[bdir.len] != 0)
+			dir = NULL;
+	}
+	if (dir == NULL) {
+		dir = apk_db_dir_get(db, bdir);
+		if (ctx != NULL) {
+			ctx->dircache = dir;
+			ctx->file_dir_node = &dir->files.first;
+		}
+	}
+
+	hlist_for_each_entry(file, cur, &dir->files, dir_files_list) {
+		if (strncmp(file->filename, bfile.ptr, bfile.len) == 0 &&
+		    file->filename[bfile.len] == 0)
+			return file;
+	}
+
+	file = apk_db_file_new(dir, bfile, ctx->file_dir_node);
+	ctx->file_dir_node = &file->dir_files_list.next;
+
+	return file;
+}
+
+static int apk_db_read_fdb(struct apk_database *db, int fd)
+{
+	struct apk_package *pkg = NULL;
+	struct apk_db_dir *dir = NULL;
+	struct apk_db_file *file = NULL;
+	struct hlist_node **pkg_node = &db->installed.packages.first;
+	struct hlist_node **file_dir_node = NULL;
+	struct hlist_node **file_pkg_node = NULL;
+
+	char buf[1024];
+	apk_blob_t l, r;
+	csum_t csum;
+	int n;
+
+	r = APK_BLOB_PTR_LEN(buf, 0);
+	while (1) {
+		n = read(fd, &r.ptr[r.len], sizeof(buf) - r.len);
+		if (n <= 0)
+			break;
+		r.len += n;
+
+		while (apk_blob_splitstr(r, "\n", &l, &r)) {
+			n = l.ptr[0];
+			l.ptr++;
+			l.len--;
+			switch (n) {
+			case 'P':
+				if (apk_hexdump_parse(APK_BLOB_BUF(csum), l)) {
+					apk_error("Not a valid checksum");
+					return -1;
+				}
+				pkg = apk_db_get_pkg(db, csum);
+				if (pkg == NULL) {
+					apk_error("Package '%.*s' is installed, but not in any repository",
+						  l.len, l.ptr);
+					return -1;
+				}
+				if (!hlist_hashed(&pkg->installed_pkgs_list)) {
+					db->installed.stats.packages++;
+					hlist_add_after(&pkg->installed_pkgs_list, pkg_node);
+					pkg_node = &pkg->installed_pkgs_list.next;
+				}
+				dir = NULL;
+				file_dir_node = NULL;
+				file_pkg_node = &pkg->owned_files.first;
+				break;
+			case 'D':
+				if (pkg == NULL) {
+					apk_error("FDB directory entry before package entry");
+					return -1;
+				}
+				dir = apk_db_dir_get(db, l);
+				file_dir_node = &dir->files.first;
+				break;
+			case 'F':
+				if (dir == NULL) {
+					apk_error("FDB file entry before directory entry");
+					return -1;
+				}
+				file = apk_db_file_new(dir, l, file_dir_node);
+				apk_db_file_set_owner(db, file, pkg, FALSE, file_pkg_node);
+				file_dir_node = &file->dir_files_list.next;
+				file_pkg_node = &file->pkg_files_list.next;
+				break;
+			default:
+				apk_error("FDB entry '%c' unsupported", n);
+				return -1;
+			}
+		}
+
+		memcpy(&buf[0], r.ptr, r.len);
+		r = APK_BLOB_PTR_LEN(buf, r.len);
+	}
+
+	return 0;
+}
+
+static int apk_db_write_fdb(struct apk_database *db, int fd)
+{
+	struct apk_package *pkg;
+	struct apk_db_dir *dir;
+	struct apk_db_file *file;
+	struct hlist_node *c1, *c2;
+	char buf[1024];
+	int n;
+
+	hlist_for_each_entry(pkg, c1, &db->installed.packages, installed_pkgs_list) {
+		n = 0;
+		buf[n++] = 'P';
+		n += apk_hexdump_format(sizeof(buf)-n, &buf[n],
+					APK_BLOB_BUF(pkg->csum));
+		buf[n++] = '\n';
+
+		dir = NULL;
+		hlist_for_each_entry(file, c2, &pkg->owned_files, pkg_files_list) {
+			if (file->owner == NULL)
+				continue;
+
+			if (dir != file->dir) {
+				n += snprintf(&buf[n], sizeof(buf)-n,
+					     "D%s\n",
+					      file->dir->dirname);
+				dir = file->dir;
+			}
+
+			n += snprintf(&buf[n], sizeof(buf)-n,
+				      "F%s\n",
+				      file->filename);
+
+			write(fd, buf, n);
+			n = 0;
+		}
+	}
+
+	return 0;
+}
+
+struct apk_script_header {
+	csum_t csum;
+	unsigned int type;
+	unsigned int size;
+};
+
+static int apk_db_write_scriptdb(struct apk_database *db, int fd)
+{
+	struct apk_package *pkg;
+	struct apk_script *script;
+	struct apk_script_header hdr;
+	struct hlist_node *c1, *c2;
+
+	hlist_for_each_entry(pkg, c1, &db->installed.packages,
+			     installed_pkgs_list) {
+		hlist_for_each_entry(script, c2, &pkg->scripts, script_list) {
+			memcpy(hdr.csum, pkg->csum, sizeof(csum_t));
+			hdr.type = script->type;
+			hdr.size = script->size;
+
+			write(fd, &hdr, sizeof(hdr));
+			write(fd, script->script, script->size);
+		}
+	}
+
+	return 0;
+}
+
+static int apk_db_read_scriptdb(struct apk_database *db, int fd)
+{
+	struct apk_package *pkg;
+	struct apk_script_header hdr;
+
+	while (read(fd, &hdr, sizeof(hdr)) == sizeof(hdr)) {
+		pkg = apk_db_get_pkg(db, hdr.csum);
+		apk_pkg_add_script(pkg, fd, hdr.type, hdr.size);
+	}
+
+	return 0;
+}
+
+static const char *get_db_path(struct apk_database *db, const char *f)
+{
+	static char fn[1024];
+
+	snprintf(fn, sizeof(fn), "%s%s", db->root, f);
+
+	return fn;
+}
+
+void apk_db_init(struct apk_database *db, const char *root)
+{
+	memset(db, 0, sizeof(*db));
+	apk_hash_init(&db->available.names, &pkg_name_hash_ops, 1000);
+	apk_hash_init(&db->available.packages, &pkg_info_hash_ops, 4000);
+	apk_hash_init(&db->installed.dirs, &dir_hash_ops, 1000);
+
+	if (root != NULL) {
+		db->root = strdup(root);
+		apk_db_add_repository(db, "/home/fabled/foo/");
+		mkdir(get_db_path(db, "tmp"), 01777);
+		mkdir(get_db_path(db, "dev"), 0755);
+		mknod(get_db_path(db, "dev/null"), 0666, makedev(1, 3));
+	}
+}
+
+int apk_db_read_config(struct apk_database *db)
+{
+	struct stat st;
+	char *buf;
+	int fd;
+
+	if (db->root == NULL)
+		return -1;
+
+	/* Read:
+	 * 1. installed repository
+	 * 2. source repositories
+	 * 3. master dependencies
+	 * 4. package statuses
+	 * 5. files db
+	 * 6. script db
+	 */
+	fd = open(get_db_path(db, "var/lib/apk/world"), O_RDONLY);
+	if (fd >= 0) {
+		fstat(fd, &st);
+		buf = malloc(st.st_size);
+		read(fd, buf, st.st_size);
+		apk_deps_parse(db, &db->world,
+			       APK_BLOB_PTR_LEN(buf, st.st_size));
+		close(fd);
+	} else {
+		apk_deps_parse(db, &db->world,
+			       APK_BLOB_STR("busybox, alpine-baselayout, "
+					    "apk-tools, alpine-conf"));
+	}
+
+	fd = open(get_db_path(db, "var/lib/apk/files"), O_RDONLY);
+	if (fd >= 0) {
+		apk_db_read_fdb(db, fd);
+		close(fd);
+	}
+
+	fd = open(get_db_path(db, "var/lib/apk/scripts"), O_RDONLY);
+	if (fd >= 0) {
+		apk_db_read_scriptdb(db, fd);
+		close(fd);
+	}
+
+	return 0;
+}
+
+struct write_ctx {
+	struct apk_database *db;
+	int fd;
+};
+
+int apk_db_write_config(struct apk_database *db)
+{
+	char buf[1024];
+	int n, fd;
+
+	if (db->root == NULL)
+		return -1;
+
+	mkdir(get_db_path(db, "var"), 0755);
+	mkdir(get_db_path(db, "var/lib"), 0755);
+	mkdir(get_db_path(db, "var/lib/apk"), 0755);
+
+	fd = creat(get_db_path(db, "var/lib/apk/world"), 0600);
+	if (fd < 0)
+		return -1;
+	n = apk_deps_format(buf, sizeof(buf), db->world);
+	write(fd, buf, n);
+	close(fd);
+
+	fd = creat(get_db_path(db, "var/lib/apk/files"), 0600);
+	if (fd < 0)
+		return -1;
+	apk_db_write_fdb(db, fd);
+	close(fd);
+
+	fd = creat(get_db_path(db, "var/lib/apk/scripts"), 0600);
+	if (fd < 0)
+		return -1;
+	apk_db_write_scriptdb(db, fd);
+	close(fd);
+
+	return 0;
+}
+
+void apk_db_free(struct apk_database *db)
+{
+	apk_hash_free(&db->available.names);
+	apk_hash_free(&db->available.packages);
+	apk_hash_free(&db->installed.dirs);
+	if (db->root != NULL)
+		free(db->root);
+}
+
+static void apk_db_pkg_add(struct apk_database *db, struct apk_package *pkg)
+{
+	struct apk_package *idb;
+
+	idb = apk_hash_get(&db->available.packages, pkg->csum);
+	if (idb == NULL) {
+		pkg->id = db->pkg_id++;
+		apk_hash_insert(&db->available.packages, pkg);
+		*apk_package_array_add(&pkg->name->pkgs) = pkg;
+	} else {
+		idb->repos |= pkg->repos;
+		apk_pkg_free(pkg);
+	}
+}
+
+struct apk_package *apk_db_get_pkg(struct apk_database *db, csum_t sum)
+{
+	return apk_hash_get(&db->available.packages, sum);
+}
+
+int apk_db_pkg_add_file(struct apk_database *db, const char *file)
+{
+	struct apk_package *info;
+
+	info = apk_pkg_read(db, file);
+	if (info == NULL)
+		return FALSE;
+
+	apk_db_pkg_add(db, info);
+	return TRUE;
+}
+
+int apk_db_index_read(struct apk_database *db, int fd, int repo)
+{
+	struct apk_package *pkg;
+	char buf[1024];
+	int n;
+	apk_blob_t l, r;
+
+	r = APK_BLOB_PTR_LEN(buf, 0);
+	while (1) {
+		n = read(fd, &r.ptr[r.len], sizeof(buf) - r.len);
+		if (n <= 0)
+			break;
+		r.len += n;
+
+		while (apk_blob_splitstr(r, "\n\n", &l, &r)) {
+			pkg = apk_pkg_parse_index_entry(db, l);
+			if (pkg != NULL) {
+				pkg->repos |= BIT(repo);
+				apk_db_pkg_add(db, pkg);
+			}
+		}
+
+		memcpy(&buf[0], r.ptr, r.len);
+		r = APK_BLOB_PTR_LEN(buf, r.len);
+	}
+
+	return 0;
+}
+
+static int write_index_entry(apk_hash_item item, void *ctx)
+{
+	int fd = (int) ctx;
+	char buf[1024];
+	apk_blob_t blob;
+
+	blob = apk_pkg_format_index_entry(item, sizeof(buf), buf);
+	if (blob.ptr)
+		write(fd, blob.ptr, blob.len);
+
+	return 0;
+}
+
+void apk_db_index_write(struct apk_database *db, int fd)
+{
+	apk_hash_foreach(&db->available.packages, write_index_entry, (void *) fd);
+}
+
+int apk_db_add_repository(struct apk_database *db, const char *repo)
+{
+	char tmp[256];
+	int fd, r;
+
+	if (db->num_repos >= APK_MAX_REPOS)
+		return -1;
+
+	r = db->num_repos++;
+	db->repos[r] = (struct apk_repository){
+		.url = strdup(repo)
+	};
+
+	snprintf(tmp, sizeof(tmp), "%sAPK_INDEX", repo);
+	fd = open(tmp, O_RDONLY);
+	if (fd < 0) {
+		apk_error("Failed to open index file %s", tmp);
+		return -1;
+	}
+	apk_db_index_read(db, fd, r);
+	close(fd);
+
+	return 0;
+}
+
+int apk_db_recalculate_and_commit(struct apk_database *db)
+{
+	struct apk_state *state;
+	int r;
+
+	state = apk_state_new(db);
+	r = apk_state_satisfy_deps(state, db->world);
+	if (r == 0) {
+		r = apk_state_commit(state, db);
+		if (r != 0) {
+			apk_error("Failed to commit changes");
+			return r;
+		}
+		apk_db_write_config(db);
+
+		apk_message("OK: %d packages, %d dirs, %d files",
+			    db->installed.stats.packages,
+			    db->installed.stats.dirs,
+			    db->installed.stats.files);
+	} else {
+		apk_error("Failed to build installation graph");
+	}
+	apk_state_unref(state);
+
+	return r;
+}
+
+static int apk_db_install_archive_entry(struct apk_archive_entry *ae,
+					struct install_ctx *ctx)
+{
+	struct apk_database *db = ctx->db;
+	struct apk_package *pkg = ctx->pkg;
+	apk_blob_t name = APK_BLOB_STR(ae->name);
+	struct apk_db_file *file;
+	const char *p;
+	int r = 0, type;
+
+	if (strncmp(ae->name, "var/db/apk/", 11) == 0) {
+		p = &ae->name[11];
+		if (strncmp(p, pkg->name->name, strlen(pkg->name->name)) != 0)
+			return 0;
+		p += strlen(pkg->name->name) + 1;
+		if (strncmp(p, pkg->version, strlen(pkg->version)) != 0)
+			return 0;
+		p += strlen(pkg->version) + 1;
+
+		type = apk_script_type(p);
+		if (type < 0)
+			return 0;
+
+		ae->size -= apk_pkg_add_script(pkg, ae->read_fd,
+					       type, ae->size);
+
+		if (type == ctx->script) {
+			r = apk_pkg_run_script(pkg, db->root, type);
+			if (r != 0)
+				apk_error("%s-%s: Failed to execute pre-install/upgrade script",
+					  pkg->name->name, pkg->version);
+		}
+
+		return r;
+	}
+
+	if (ctx->file_pkg_node == NULL)
+		ctx->file_pkg_node = &pkg->owned_files.first;
+
+	if (!S_ISDIR(ae->mode)) {
+		file = apk_db_file_get(db, name, ctx);
+		if (file == NULL)
+			return -1;
+
+		if (file->owner != NULL &&
+		    file->owner->name != pkg->name) {
+			apk_error("%s: Trying to overwrite %s owned by %s.\n",
+				  pkg->name->name, ae->name,
+				  file->owner->name->name);
+			return -1;
+		}
+
+		apk_db_file_set_owner(db, file, pkg, TRUE, ctx->file_pkg_node);
+		ctx->file_pkg_node = &file->pkg_files_list.next;
+
+		if (strncmp(file->filename, ".keep_", 6) == 0)
+			return 0;
+
+		r = apk_archive_entry_extract(ae, NULL);
+	} else {
+		if (name.ptr[name.len-1] == '/')
+			name.len--;
+		apk_db_dir_get(db, name)->mode = 0777 & ae->mode;
+	}
+
+	return r;
+}
+
+static void apk_db_purge_pkg(struct apk_database *db,
+			     struct apk_package *pkg)
+{
+	struct apk_db_file *file;
+	struct hlist_node *c, *n;
+	char fn[1024];
+
+	hlist_for_each_entry_safe(file, c, n, &pkg->owned_files, pkg_files_list) {
+		file->owner = NULL;
+		snprintf(fn, sizeof(fn), "%s/%s",
+			 file->dir->dirname,
+			 file->filename);
+		unlink(fn);
+
+		apk_db_dir_unref(db, file->dir);
+		hlist_del(c, &pkg->owned_files.first);
+
+		db->installed.stats.files--;
+	}
+	db->installed.stats.packages--;
+}
+
+int apk_db_install_pkg(struct apk_database *db,
+		       struct apk_package *oldpkg,
+		       struct apk_package *newpkg)
+{
+	struct install_ctx ctx;
+	csum_t csum;
+	char file[256];
+	pthread_t tid = 0;
+	int fd, r;
+
+	if (chdir(db->root) < 0)
+		return errno;
+
+	/* Purge the old package if there */
+	if (oldpkg != NULL) {
+		if (newpkg == NULL) {
+			r = apk_pkg_run_script(oldpkg, db->root,
+					       APK_SCRIPT_PRE_DEINSTALL);
+			if (r != 0)
+				return r;
+		}
+		apk_db_purge_pkg(db, oldpkg);
+		if (newpkg == NULL) {
+			apk_pkg_run_script(oldpkg, db->root,
+					   APK_SCRIPT_POST_DEINSTALL);
+			return 0;
+		}
+	}
+
+	/* Install the new stuff */
+	snprintf(file, sizeof(file),
+		 "%s%s-%s.apk",
+		 db->repos[0].url, newpkg->name->name, newpkg->version);
+
+	fd = open(file, O_RDONLY);
+	if (fd < 0)
+		return errno;
+
+	fcntl(fd, F_SETFD, FD_CLOEXEC);
+
+	tid = apk_checksum_and_tee(&fd, csum);
+	if (tid < 0)
+		goto err_close;
+
+	ctx = (struct install_ctx) {
+		.db = db,
+		.pkg = newpkg,
+		.script = (oldpkg == NULL) ?
+			APK_SCRIPT_PRE_INSTALL : APK_SCRIPT_PRE_UPGRADE,
+	};
+	if (apk_parse_tar_gz(fd, (apk_archive_entry_parser)
+			     apk_db_install_archive_entry, &ctx) != 0)
+		goto err_close;
+
+	pthread_join(tid, NULL);
+	close(fd);
+
+	db->installed.stats.packages++;
+	hlist_add_head(&newpkg->installed_pkgs_list, &db->installed.packages);
+
+	if (memcmp(csum, newpkg->csum, sizeof(csum)) != 0)
+		apk_warning("%s-%s: checksum does not match",
+			    newpkg->name->name, newpkg->version);
+
+	r = apk_pkg_run_script(newpkg, db->root,
+			       (oldpkg == NULL) ?
+			       APK_SCRIPT_POST_INSTALL : APK_SCRIPT_POST_UPGRADE);
+	if (r != 0)
+		apk_error("%s-%s: Failed to execute post-install/upgrade script",
+			  newpkg->name->name, newpkg->version);
+	return r;
+
+err_close:
+	close(fd);
+	if (tid != 0)
+		pthread_join(tid, NULL);
+	return -1;
+}