summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-11-15fs_fsys: fix extraction of symlinksTimo Teräs1-6/+8
Symlinks should use the real target filename instead of the temporary extraction name.
2021-11-15extract_v2: handle "untrusted package" as normal errorTimo Teräs1-1/+1
The "untrusted" error is higher priority than malformed package. But given that we expect valid .apk or index as argument, the untrusted error is likely more accurate than having malformed package.
2021-11-15commit: print download size of packages in interactive modeTimo Teräs1-3/+12
ref #10788
2021-11-15fix fetching of depdencies only packagesTimo Teräs4-16/+12
Remove the APK_REPOSITORY_CACHED bit from dependencies only packages (that is, installed_size == 0). For fetch, the problem is that apk_db_select_repo() would return the cache repository, but the package would not be there. Update also the locations needed to handle these packages correctly without the cached repository bit being set.
2021-11-12fetch: add --url option to print the download URLsTimo Teräs2-6/+17
2021-11-11pkg: fix reading of v3 package meta dataTimo Teräs1-1/+1
The adb object for apk_pkg_from_adb() was changed in commit 7d6de220 "database: support loading v3 indexes" which also addressed the broken site in question but omitted updating the argument. fixes #10783
2021-11-11pathbuilder: fix push return valueTimo Teräs1-2/+2
Always return the original length; not the one with trailing '/' amended. fixes c60b7424 "optimize apk_pathbuilder_pop to get the old length" ref #10784
2021-11-11extract_v3: fix extraction of zero length filesTimo Teräs1-2/+3
The apk_istream is null for zero length files, and needs special handling. fixes #10784
2021-11-09optimize apk_pathbuilder_pop to get the old lengthTimo Teräs5-21/+21
avoids memrchr
2021-11-09adbdump: fix dumping signaturesTimo Teräs1-1/+4
give a fake trust root allowing anything. adbdump code will verify and dump each signature individually.
2021-11-09database: support loading v3 indexesTimo Teräs5-20/+56
2021-11-09database: implement uvol supportTimo Teräs19-434/+710
by adding an abstraction layer to the file system
2021-11-03db: purge temporary files without explicit modification checkTimo Teräs1-1/+2
When extraction failed, the user has had no opportunity to edit any files. Just clean up.
2021-11-03extract: move uvol extraction code to extractTimo Teräs4-97/+99
fix also the progress callback on uvol extraction
2021-11-03db, extract: handle waitpid returning EINTRTimo Teräs2-3/+3
2021-11-03db, audit: support sha256-160 hashes for v3 pkg compatTimo Teräs6-13/+33
2021-10-27db, add: support adding v3 package filesTimo Teräs9-14/+144
2021-10-25mkpkg: make unique-id field a blobTimo Teräs4-2/+30
2021-10-25version: increase number of digits supported in version componentTimo Teräs3-3/+8
Report also version numbers as invalid if there's more than 18 digits. fixes #10774
2021-10-04enable uvol support by defaultTimo Teräs1-1/+1
2021-09-13adb: fix --allow-untrusted to work againTimo Teräs2-4/+11
and fix the error code if untrusted adb is seen
2021-09-03test: improve posix sh compatibilityAlex Xu (Hello71)3-5/+5
2021-09-03extract: remove redundant file unlink on failure pathTimo Teräs1-1/+0
apk_extract_file() already calls unlink if the error is fatal.
2021-09-03extract: pass root object instead of databaseTimo Teräs5-19/+19
2021-09-03add: warn when creating empty virtual packagesAlex Xu (Hello71)2-0/+3
see https://gitlab.alpinelinux.org/alpine/aports/-/issues/11736 [TT: minor stylistic change]
2021-08-24tar: include missing limits.hPaul Spooren1-0/+1
Without this header the build fails when used as a OpenWrt build dependency. Signed-off-by: Paul Spooren <mail@aparcar.org>
2021-08-23mkpkg: add support for scripts and triggersTimo Teräs2-1/+37
2021-08-23trust: always use have valid struct apk_trust *Timo Teräs5-25/+26
Make sure we always have valid struct apk_trust * for code using it. Load the signing keys directly when being specified to produce sane error message if loading them fails.
2021-08-23remove IS_ERR_OR_NULLTimo Teräs11-22/+21
In most places where pointer can be an 'error' it cannot be null pointer. Further, in those cases just calling PTR_ERR() is not enough to handle the null case. Simplify code by removing this case. If NULL case needs to be handled, it's better to add separate check and return fixed error code in that case.
2021-08-23extract: support v3 index verificationTimo Teräs2-5/+29
2021-08-23tar: improve compatibilityTimo Teräs1-20/+30
- check magic field for 'ustar' on read - harden get_octal to report errors on non-octal characters (e.g. GNU base256 encoding), fixes #10757 - fix mtime and size octal fields to not have zero terminator
2021-08-23db: honor SOURCE_DATE_EPOCH for scriptdbTimo Teräs1-2/+0
fixes #10762
2021-08-23list: recognize both --upgradable and --upgradeableTimo Teräs2-2/+4
fixes #10759
2021-08-17extract: fix directory handlingTimo Teräs1-7/+8
'is' is null for directories
2021-08-03extract: fix --force-overwriteTimo Teräs1-1/+1
Directories are handled specially in package installation code, but extract applet uses also apk_extract_file() to create directories. These should not be unlinked as that fails with unexpected error code terminating the extraction.
2021-08-03libfetch: fix http chunked mode handlingTimo Teräs1-1/+1
Unbreak handling of base 16 in fetch_parseuint(). It is used only in http chunked mode handling. Fixes: "libfetch: fix range checking for http/ftp protocol parsing"
2021-08-03extract: fix extracting untrusted packageTimo Teräs2-3/+6
2021-07-30manifest: support v3 packagesTimo Teräs1-0/+42
2021-07-30verify: support v3 packagesTimo Teräs2-4/+24
2021-07-30mkndx: support v3 packagesTimo Teräs1-0/+14
2021-07-30extract: use extraction api, and implement it for v3 packagesTimo Teräs6-209/+298
The extract applet now works with both v2 and v3 packages.
2021-07-27Further refactor extract API to have separate ops vtableTimo Teräs7-135/+162
This splits the callbacks by type, and further prepares the API to be usable for v3 files too.
2021-07-27Refactor .apk extraction codeTimo Teräs25-749/+744
This moves and isolates the tar code to tar.c. And the actual file extraction to disk is moved to extract.c. A new API is introduced and used for v2 file extraction. This essentially moves and isolates the apk_sign_ctx_* beast into extract_v2.c and offers a saner interface to handling packages. A place holder is added for v3 extraction.
2021-07-26extract: fix handling of error of regular file extractionTimo Teräs2-3/+16
fix the error checking, allow --force-overwrite to work and do not delete existing file in case of error
2021-07-26libfetch: fix range checking for http/ftp protocol parsingTimo Teräs5-61/+70
Various parsing of numeric strings were not having adequate range checking causing information leak or potential crash. CVE-2021-36159 fixes #10749 Co-authored-by: Ariadne Conill <ariadne@dereferenced.org> Reported-by: Samanta Navarro <ferivoz@riseup.net>
2021-07-26adb: fix some error handling pathsTimo Teräs3-9/+9
2021-07-26db: add some error checking to database state writeTimo Teräs2-40/+51
Make errors more observable. Unfortunately full rollback is non-trivial to implement. This is something to be fixed with the v3 database format.
2021-07-26db: fix installed db writing with long namesSamanta Navarro1-5/+10
Packages containing files with path names longer than 1024 characters cannot fit into the buffer which is used to write "installed" database. This leads to bbuf being APK_BLOB_NULL in apk_db_write_fdb because apk_blob_push_blob notices the condition and correctly handles it. The problem occurs when arguments to apk_ostream_write are manually calculated by pointer arithmetics. Since bbuf.ptr is NULL in such a case, bbuf.ptr - buf leads to a huge size value while buf still points into the stack. fixes #10751 [TT: minor edit to commit and abbreviating the commit message]
2021-07-26Use __attribute__ ((format)) where possible and fix issues found by itTimo Teräs4-8/+9
2021-07-26adb: adb_walk_adb fix out of boundary writeTimo Teräs3-37/+58
If a signature is longer than max allowed adb signature length then adb_walk_block writes out of boundary of stack variable tmp. The len += snprintf is not safe per standard snprintf implementation (kernel does it differently). Introduce and use apk_blob_push_fmt which does the checking better. Fixes #10752 Reported-by: Samanta Navarro <ferivoz@riseup.net>