summaryrefslogtreecommitdiff
path: root/crt
diff options
context:
space:
mode:
authorAlexander Monakov <amonakov@ispras.ru>2017-09-03 22:12:20 +0300
committerRich Felker <dalias@aerifal.cx>2017-09-04 15:55:05 -0400
commit8e932792c917d11545c2953b35159149f7411eca (patch)
tree330b20d848bf624c9b7a00c1c0ae0181e3b85e93 /crt
parent39db00afadc9d8d0456c46eab42b8cb8ff9f375c (diff)
downloadmusl-8e932792c917d11545c2953b35159149f7411eca.tar.gz
musl-8e932792c917d11545c2953b35159149f7411eca.tar.bz2
musl-8e932792c917d11545c2953b35159149f7411eca.tar.xz
musl-8e932792c917d11545c2953b35159149f7411eca.zip
overhaul environment functions
Rewrite environment access functions to slim down code, fix bugs and avoid invoking undefined behavior. * avoid using int-typed iterators where size_t would be correct; * use strncmp instead of memcmp consistently; * tighten prologues by invoking __strchrnul; * handle NULL environ. putenv: * handle "=value" input via unsetenv too (will return -1/EINVAL); * rewrite and simplify __putenv; fix the leak caused by failure to deallocate entry added by preceding setenv when called from putenv. setenv: * move management of libc-allocated entries to this translation unit, and use no-op weak symbols in putenv/unsetenv; unsetenv: * rewrite; this fixes UB caused by testing a free'd pointer against NULL on entry to subsequent loops. Not changed: Failure to extend allocation tracking array (previously __env_map, now env_alloced) is ignored rather than causing to report -1/ENOMEM to the caller; the worst-case consequence is leaking this allocation when it is removed or replaced in a subsequent environment access. Initially UB in unsetenv was reported by Alexander Cherepanov. Using a weak alias to avoid pulling in malloc via unsetenv was suggested by Rich Felker.
Diffstat (limited to 'crt')
0 files changed, 0 insertions, 0 deletions