clean up and refactor program initialization

the code in __libc_start_main is now responsible for parsing auxv,
rather than duplicating the parsing all over the place. this should
shave off a few cycles and some code size. __init_libc is left as an
external-linkage function despite the fact that it could be static, to
prevent it from being inlined and permanently wasting stack space when
main is called.

a few other minor changes are included, like eliminating per-thread
ssp canaries (they were likely broken when combined with certain
dlopen usages, and completely unnecessary) and some other unnecessary
checks. since this code gets linked into every program, it should be
as small and simple as possible.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/thread/pthread_create.c b/src/thread/pthread_create.c
index 92ce9ffb..6327a942 100644
--- a/src/thread/pthread_create.c
+++ b/src/thread/pthread_create.c
@@ -144,7 +144,7 @@ int pthread_create(pthread_t *restrict res, const pthread_attr_t *restrict attr,
 		flags -= 0x200000;
 	}
 	new->unblock_cancel = self->cancel;
-	new->canary = self->canary ^ (uintptr_t)&new;
+	new->canary = self->canary;
 	stack = (void *)new;
 
 	a_inc(&libc.threads_minus_1);