Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2018-09-16 | fix null pointer subtraction and comparison in stdio | Rich Felker | 1 | -4/+3 | |
morally, for null pointers a and b, a-b, a<b, and a>b should all be defined as 0; however, C does not define any of them. the stdio implementation makes heavy use of such pointer comparison and subtraction for buffer logic, and also uses null pos/base/end pointers to indicate that the FILE is not in the corresponding (read or write) mode ready for accesses through the buffer. all of the comparisons are fixed trivially by using != in place of the relational operators, since the opposite relation (e.g. pos>end) is logically impossible. the subtractions have been reviewed to check that they are conditional the stream being in the appropriate reading- or writing-through-buffer mode, with checks added where needed. in fgets and getdelim, the checks added should improve performance for unbuffered streams by avoiding a do-nothing call to memchr, and should be negligible for buffered streams. | |||||
2018-09-12 | fix issues from public functions defined without declaration visible | Rich Felker | 1 | -0/+1 | |
policy is that all public functions which have a public declaration should be defined in a context where that public declaration is visible, to avoid preventable type mismatches. an audit performed using GCC's -Wmissing-declarations turned up the violations corrected here. in some cases the public header had not been included; in others, a feature test macro needed to make the declaration visible had been omitted. in the case of gethostent and getnetent, the omission seems to have been intentional, as a hack to admit a single stub definition for both functions. this kind of hack is no longer acceptable; it's UB and would not fly with LTO or advanced toolchains. the hack is undone to make exposure of the declarations possible. | |||||
2012-09-06 | fix invalid implicit pointer conversion in gnulib-compat functions | Rich Felker | 1 | -1/+1 | |
2012-06-19 | add new stdio extension functions to make gnulib happy | Rich Felker | 1 | -0/+24 | |
this is mildly ugly, but less ugly than gnulib trying to poke at the definition of the FILE structure... |