summaryrefslogtreecommitdiff
path: root/user/audiofile/CVE-2017-6831.patch
diff options
context:
space:
mode:
authorZach van Rijn <me@zv.io>2022-11-11 14:15:59 -0600
committerZach van Rijn <me@zv.io>2022-11-11 14:19:24 -0600
commit451e5cf47f3a45ebf46cad0940f07ef05324f4c5 (patch)
tree1592e1938805a7576fd31da137fb568eb8d5468a /user/audiofile/CVE-2017-6831.patch
parent27d6cb412d2697940aafceba923878050b1a1add (diff)
downloadpackages-451e5cf47f3a45ebf46cad0940f07ef05324f4c5.tar.gz
packages-451e5cf47f3a45ebf46cad0940f07ef05324f4c5.tar.bz2
packages-451e5cf47f3a45ebf46cad0940f07ef05324f4c5.tar.xz
packages-451e5cf47f3a45ebf46cad0940f07ef05324f4c5.zip
user/audiofile: multiple CVE patches. fixes #124.
Diffstat (limited to 'user/audiofile/CVE-2017-6831.patch')
-rw-r--r--user/audiofile/CVE-2017-6831.patch36
1 files changed, 36 insertions, 0 deletions
diff --git a/user/audiofile/CVE-2017-6831.patch b/user/audiofile/CVE-2017-6831.patch
new file mode 100644
index 000000000..50cd3dc9a
--- /dev/null
+++ b/user/audiofile/CVE-2017-6831.patch
@@ -0,0 +1,36 @@
+From: Antonio Larrosa <larrosa@kde.org>
+Date: Mon, 6 Mar 2017 18:59:26 +0100
+Subject: Actually fail when error occurs in parseFormat
+
+When there's an unsupported number of bits per sample or an invalid
+number of samples per block, don't only print an error message using
+the error handler, but actually stop parsing the file.
+
+This fixes #35 (also reported at
+https://bugzilla.opensuse.org/show_bug.cgi?id=1026983 and
+https://blogs.gentoo.org/ago/2017/02/20/audiofile-heap-based-buffer-overflow-in-imadecodeblockwave-ima-cpp/
+)
+---
+ libaudiofile/WAVE.cpp | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/libaudiofile/WAVE.cpp b/libaudiofile/WAVE.cpp
+index 0fc48e8..d04b796 100644
+--- a/libaudiofile/WAVE.cpp
++++ b/libaudiofile/WAVE.cpp
+@@ -332,6 +332,7 @@ status WAVEFile::parseFormat(const Tag &id, uint32_t size)
+ {
+ _af_error(AF_BAD_NOT_IMPLEMENTED,
+ "IMA ADPCM compression supports only 4 bits per sample");
++ return AF_FAIL;
+ }
+
+ int bytesPerBlock = (samplesPerBlock + 14) / 8 * 4 * channelCount;
+@@ -339,6 +340,7 @@ status WAVEFile::parseFormat(const Tag &id, uint32_t size)
+ {
+ _af_error(AF_BAD_CODEC_CONFIG,
+ "Invalid samples per block for IMA ADPCM compression");
++ return AF_FAIL;
+ }
+
+ track->f.sampleWidth = 16;