diff options
| author | Zach van Rijn <me@zv.io> | 2023-03-21 16:58:08 +0000 |
|---|---|---|
| committer | Zach van Rijn <me@zv.io> | 2023-03-21 17:24:04 +0000 |
| commit | c57df9efeda39dd0347a957565a60c159ef86278 (patch) | |
| tree | d69ffa5926e5e16c77d56506e7d53f30909a2bd7 /user/node/env-nullptr-backport.patch | |
| parent | b673b979e840bd379d655e98135ed8c18969a5cc (diff) | |
| download | packages-c57df9efeda39dd0347a957565a60c159ef86278.tar.gz packages-c57df9efeda39dd0347a957565a60c159ef86278.tar.bz2 packages-c57df9efeda39dd0347a957565a60c159ef86278.tar.xz packages-c57df9efeda39dd0347a957565a60c159ef86278.zip | |
user/node: bump { 18.12.1 --> 18.15.0 }. temporarily disable flaky tests.
See #971.
It is not clear whether these tests ever passed in their current form.
Upstream changed these tests (and relevant code) since v16.15.0:
https://github.com/nodejs/node/pull/41431
https://github.com/nodejs/node/issues/43014
In v16.15.0, these tests passed on this platform, but they have been
modified in subsequent releases, and we've bumped twice since then:
b282640c5353f37b706d3395718e80db244644b2 to v16.19.0
5d1083c1c688a496fbf9565046a1e22309cd9ad5 to v18.12.1
I don't see any binaries for aarch64 for either of these versions,
suggesting we never rebuilt node on aarch64 after going to v18.12.1,
likely due to the ARM builder being out of service between around
2022-12-27 and 2023-01-03. I think we just didn't catch this since
bumping to v18.12.1.
Temporarily disabling these tests to unblock progress; the
bump to v18.15.0 is for some CVEs and expected to be safe.
Diffstat (limited to 'user/node/env-nullptr-backport.patch')
| -rw-r--r-- | user/node/env-nullptr-backport.patch | 28 |
1 files changed, 0 insertions, 28 deletions
diff --git a/user/node/env-nullptr-backport.patch b/user/node/env-nullptr-backport.patch deleted file mode 100644 index 02878dc25..000000000 --- a/user/node/env-nullptr-backport.patch +++ /dev/null @@ -1,28 +0,0 @@ -From 8214cc175f0c4e600a3af5cedd94e4fd4d8d839e Mon Sep 17 00:00:00 2001 -From: "A. Wilcox" <AWilcox@Wilcox-Tech.com> -Date: Sat, 17 Dec 2022 19:39:01 -0600 -Subject: [PATCH] env: check size of args before using for exec_path - -If we are in an artifically created Environment that has no args set, -and uv_exepath returns an error (for instance, if /proc is not mounted -on a Linux system), then we crash with a nullptr deref attempting to -use argv[0]. - -Fixes: https://github.com/nodejs/node/issues/45901 ---- - src/env.cc | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/src/env.cc b/src/env.cc -index 5172d71ad6a6..97e0ac581113 100644 ---- node-v16.15.0/src/env.cc.old 2022-04-26 22:03:30.000000000 +0000 -+++ node-v16.15.0/src/env.cc 2022-12-18 01:19:23.417720353 +0000 -@@ -309,7 +309,7 @@ - std::string exec_path; - if (uv_exepath(exec_path_buf, &exec_path_len) == 0) { - exec_path = std::string(exec_path_buf, exec_path_len); -- } else { -+ } else if (argv.size() > 0) { - exec_path = argv[0]; - } - |