diff options
| author | A. Wilcox <awilcox@wilcox-tech.com> | 2018-11-28 21:37:51 +0000 |
|---|---|---|
| committer | A. Wilcox <awilcox@wilcox-tech.com> | 2018-11-28 21:37:51 +0000 |
| commit | 274f300f2855e1e2847a789900f20eb275ff16be (patch) | |
| tree | 392f34dcc143d1415a4b9b18d611efd8762ec9e5 /user/weechat/fix-unsigned-char.patch | |
| parent | 3a47ff3620d55ae20462f0bbf1751c4db65c5161 (diff) | |
| parent | e4969194f5031b1c56a9cc7aee5f0a13d8243584 (diff) | |
| download | packages-274f300f2855e1e2847a789900f20eb275ff16be.tar.gz packages-274f300f2855e1e2847a789900f20eb275ff16be.tar.bz2 packages-274f300f2855e1e2847a789900f20eb275ff16be.tar.xz packages-274f300f2855e1e2847a789900f20eb275ff16be.zip | |
Merge branch 'fix-weechat.2018-11-21' into 'master'
user/weechat: fix overzealous highlighting bug
This bug is caused by musl's default `char` type being unsigned, while weechat's codebase was assuming signed. As a result, scripts such as `urlserver.py` were triggering highlights when they shouldn't.
This fix makes the assumption explicit.
See merge request !112
Diffstat (limited to 'user/weechat/fix-unsigned-char.patch')
| -rw-r--r-- | user/weechat/fix-unsigned-char.patch | 37 |
1 files changed, 37 insertions, 0 deletions
diff --git a/user/weechat/fix-unsigned-char.patch b/user/weechat/fix-unsigned-char.patch new file mode 100644 index 000000000..d4acd1986 --- /dev/null +++ b/user/weechat/fix-unsigned-char.patch @@ -0,0 +1,37 @@ +This patch is backported from the upcoming 2.4 release. It corrects +highlighting behavior for plugins such as urlserver.py. + +See-Also: https://github.com/weechat/weechat/issues/1277 +Patch-Author: Sébastien Helleu <flashcode@flashtux.org> + +diff --git a/CMakeLists.txt b/CMakeLists.txt +index 0ae69ea0f..1d7738af5 100644 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -27,8 +27,8 @@ project(weechat C) + set(CMAKE_VERBOSE_MAKEFILE OFF) + set(CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/cmake ${CMAKE_MODULE_PATH}) + set(CMAKE_SKIP_RPATH ON) +-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Werror-implicit-function-declaration") +-set(CMAKE_CXX_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Werror-implicit-function-declaration") ++set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsigned-char -Wall -Wextra -Werror-implicit-function-declaration") ++set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsigned-char -Wall -Wextra -Werror-implicit-function-declaration") + + # version + execute_process(COMMAND ${CMAKE_SOURCE_DIR}/version.sh devel-major OUTPUT_VARIABLE VERSION_MAJOR) +diff --git a/configure.ac b/configure.ac +index d267ca10f..a0bf00078 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -1330,7 +1330,7 @@ AC_DEFINE_UNQUOTED(WEECHAT_SHAREDIR, "$WEECHAT_SHAREDIR") + weechat_libdir=${libdir}/weechat + AC_SUBST(weechat_libdir) + +-COMMON_CFLAGS="-Wall -Wextra -Werror-implicit-function-declaration" ++COMMON_CFLAGS="-fsigned-char -Wall -Wextra -Werror-implicit-function-declaration" + AC_MSG_CHECKING([whether we have GNU assembler]) + GAS=`as --version < /dev/null 2>/dev/null | grep GNU` + if test "$GAS"; then +-- +2.19.1 + |