diff options
Diffstat (limited to 'user/libgit2/remove-flaky-revparse-test.patch')
| -rw-r--r-- | user/libgit2/remove-flaky-revparse-test.patch | 40 |
1 files changed, 40 insertions, 0 deletions
diff --git a/user/libgit2/remove-flaky-revparse-test.patch b/user/libgit2/remove-flaky-revparse-test.patch new file mode 100644 index 000000000..94d6806b8 --- /dev/null +++ b/user/libgit2/remove-flaky-revparse-test.patch @@ -0,0 +1,40 @@ +This patch differs from upstream in the following way(s): + + * Changed paths + + * Changed "11 years ago" to "10 years ago" to match state + before libgit2 bdab22384cc61d315005a65456a9f9563bb27c8f + + * Changed a commit hash to 'NULL' to match source code + +From 7f53d7b600a838c19276e835fd0188c361a63801 Mon Sep 17 00:00:00 2001 +From: Carl Dong <accounts@carldong.me> +Date: Mon, 9 May 2022 12:09:08 -0400 +Subject: [PATCH] revparse: Remove error-prone, redundant test + +Originally introduced in: 776a6a8e5f8e258d31aded73c0ce38df6ac7bdc4 + +This test case has recently been fixed in bdab22384cc61d315005a65456a9f9563bb27c8f, but that fix will only last for a year. Next year the same problem will crop up and the test will need to be re-edited. + +This is not ideal as +- This test case becomes an unnecessary burden for developers +- Downstream distros or even just users who want to build older versions of libgit2 are guaranteed to have this test fail + +Furthermore, this test case is entirely unnecessary, as the functionality that was originally (see 776a6a8e5f8e258d31aded73c0ce38df6ac7bdc4) intended to be tested is well-covered by subsequent tests which specify a date instead of a "x ago" specification. +--- + tests/libgit2/refs/revparse.c | 2 -- + 1 file changed, 2 deletions(-) + +diff --git a/tests/libgit2/refs/revparse.c b/tests/libgit2/refs/revparse.c +index 93d7ce6db81..56af3c939be 100644 +--- a/tests/refs/revparse.c ++++ b/tests/refs/revparse.c +@@ -399,8 +399,6 @@ void test_refs_revparse__date(void) + * a65fedf HEAD@{1335806603 -0900}: commit: + * be3563a HEAD@{1335806563 -0700}: clone: from /Users/ben/src/libgit2/tests/resour + */ +- test_object("HEAD@{10 years ago}", NULL); +- + test_object("HEAD@{1 second}", "a65fedf39aefe402d3bb6e24df4d4f5fe4547750"); + test_object("HEAD@{1 second ago}", "a65fedf39aefe402d3bb6e24df4d4f5fe4547750"); + test_object("HEAD@{2 days ago}", "a65fedf39aefe402d3bb6e24df4d4f5fe4547750"); |