summaryrefslogtreecommitdiff
path: root/user/node/icu77.patch
diff options
context:
space:
mode:
Diffstat (limited to 'user/node/icu77.patch')
-rw-r--r--user/node/icu77.patch34
1 files changed, 34 insertions, 0 deletions
diff --git a/user/node/icu77.patch b/user/node/icu77.patch
new file mode 100644
index 000000000..29553aa39
--- /dev/null
+++ b/user/node/icu77.patch
@@ -0,0 +1,34 @@
+Upstream-URL: https://github.com/nodejs/node/pull/55563
+See-also: https://bugs.gentoo.org/943201
+
+From 046430c47efb5ac758253d4e2d2fd539fa94535b Mon Sep 17 00:00:00 2001
+From: Michael Cho <michael@michaelcho.dev>
+Date: Tue, 29 Oct 2024 19:24:38 -0400
+Subject: [PATCH] build: fix building with system icu 76
+
+ICU 76 decided to reduce overlinking[^1] thus `icu-i18n` will no longer
+add `icu-uc` when linking to shared libraries. This results in undefined
+symbols/references when trying to build with system ICU 76.
+
+[^1]: unicode-org/icu@199bc82
+
+PR-URL: https://github.com/nodejs/node/pull/55563
+Reviewed-By: Richard Lau <rlau@redhat.com>
+Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
+---
+ configure.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure.py b/configure.py
+index 6cfb95eee95690..ae3dd156d4e02e 100755
+--- a/configure.py
++++ b/configure.py
+@@ -1763,7 +1763,7 @@ def icu_download(path):
+ elif with_intl == 'system-icu':
+ # ICU from pkg-config.
+ o['variables']['v8_enable_i18n_support'] = 1
+- pkgicu = pkg_config('icu-i18n')
++ pkgicu = pkg_config(['icu-i18n', 'icu-uc'])
+ if not pkgicu[0]:
+ error('''Could not load pkg-config data for "icu-i18n".
+ See above errors or the README.md.''')