diff options
author | Seth R. Johnson <johnsonsr@ornl.gov> | 2021-11-02 12:04:29 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-11-02 17:04:29 +0100 |
commit | 9cfecec002cc8951e3e8185d641db7baab6abd8f (patch) | |
tree | 3872064f1f4fa9f479ed0d5d81edc49eff786b18 /.codecov.yml | |
parent | 34b274281710aef3d8c6be9cf2401442ed328fec (diff) | |
download | spack-9cfecec002cc8951e3e8185d641db7baab6abd8f.tar.gz spack-9cfecec002cc8951e3e8185d641db7baab6abd8f.tar.bz2 spack-9cfecec002cc8951e3e8185d641db7baab6abd8f.tar.xz spack-9cfecec002cc8951e3e8185d641db7baab6abd8f.zip |
relocate: do not change library id to use rpaths on package install (#27139)
After #26608 I got a report about missing rpaths when building a
downstream package independently using a spack-installed toolchain
(@tmdelellis). This occurred because the spack-installed libraries were
being linked into the downstream app, but the rpaths were not being
manually added. Prior to #26608 autotools-installed libs would retain
their hard-coded path and would thus propagate their link information
into the downstream library on mac.
We could solve this problem *if* the mac linker (ld) respected
`LD_RUN_PATH` like it does on GNU systems, i.e. adding `rpath` entries
to each item in the environment variable. However on mac we would have
to manually add rpaths either using spack's compiler wrapper scripts or
manually (e.g. using `CMAKE_BUILD_RPATH` and pointing to the libraries of
all the autotools-installed spack libraries).
The easier and safer thing to do for now is to simply stop changing the
dylib IDs.
Diffstat (limited to '.codecov.yml')
0 files changed, 0 insertions, 0 deletions