diff options
author | George Hartzell <hartzell@alerce.com> | 2017-10-09 14:14:19 -0700 |
---|---|---|
committer | Todd Gamblin <tgamblin@llnl.gov> | 2017-10-09 14:14:19 -0700 |
commit | 0d1c36e5596fd880fae3e2e883ac7a0752df36c1 (patch) | |
tree | 623b4048652c25d6dff71adeaa0cc276b6bbc236 /.coveragerc | |
parent | 5ccc9c17dcab7a19aac666755511591dbbff3a2b (diff) | |
download | spack-0d1c36e5596fd880fae3e2e883ac7a0752df36c1.tar.gz spack-0d1c36e5596fd880fae3e2e883ac7a0752df36c1.tar.bz2 spack-0d1c36e5596fd880fae3e2e883ac7a0752df36c1.tar.xz spack-0d1c36e5596fd880fae3e2e883ac7a0752df36c1.zip |
Add package for aspell and ass't dictionaries (#3890)
* Add package for aspell and ass't dictionaries
Add a package definition for aspell.
Add a handful of dictionaries to convince myself that the support for
a bunch of dictionaries works.
* Flake8 cleanup
* Use six's version of urlparse
`urlparse` is not python3 friendly. This works around it (stolen from
`.../cmd/md5.py`).
* Fix incorrect trimming regexp
* Clean up dictionary build
- more parsimonious use of `which` (`make()` has already been made)
- use `sh` instead of `bash`
* Use a helper method to generate info for variants
I figured out my issues with static methods. I *think* that it this
is pythonic.
* Convert aspell to an extendable package
Convert aspell to be extendable and rework the dictionaries to be
extensions.
As it stands, there's a great deal of cut and paste in the
dictionaries, I'll abstract that out next.
The {de,}activate methods copy a great deal of code out of
package.py. Perhaps there's a better way....
* Create AspellDictPackage and use it for the dictionaries
Reduce the repeated code, pull it into a base class.
I'm confused about why 'from spack import *' wasn't more useful in the
base class.
* Oops, -de & -es should be AspellDictPackages too
* Typo: pakcage -> package
* Address some commentary
* Update copyright dates, 2016->2017
Diffstat (limited to '.coveragerc')
0 files changed, 0 insertions, 0 deletions