diff options
| author | Todd Gamblin <tgamblin@llnl.gov> | 2019-04-20 20:51:45 -0700 |
|---|---|---|
| committer | Greg Becker <becker33@llnl.gov> | 2019-04-20 20:51:45 -0700 |
| commit | 0aed3bcea676a9df4a5c1c26a9a5ca7151d85215 (patch) | |
| tree | 42574589e07bccca775d63827976fcc9e7016933 /.coveragerc | |
| parent | 5fb6145f6f058776c26b5792a45ecdb5ee998464 (diff) | |
| download | spack-0aed3bcea676a9df4a5c1c26a9a5ca7151d85215.tar.gz spack-0aed3bcea676a9df4a5c1c26a9a5ca7151d85215.tar.bz2 spack-0aed3bcea676a9df4a5c1c26a9a5ca7151d85215.tar.xz spack-0aed3bcea676a9df4a5c1c26a9a5ca7151d85215.zip | |
spack edit: use execv instead of Executable (#11245)
- `spack edit` previously used `spack.util.executable` `Executable` objects,
and didn't `exec` the editor like you'd expect it to
- This meant that Spack was still running while your editor was, and
stdout/stdin were being set up in weird ways
- e.g. on macOS, if you call `spack edit` with `EDITOR` set to the
builtin `emacs` command, then type `Ctrl-g`, the whole thing dies with
a `==> Error: Keyboard interrupt`
- Fix all this by changing spack.util.editor to use `os.execv` instead of
Spack's `Executable` object
Diffstat (limited to '.coveragerc')
0 files changed, 0 insertions, 0 deletions