diff options
author | Harmen Stoppels <harmenstoppels@gmail.com> | 2021-11-17 17:14:05 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-11-17 09:14:05 -0700 |
commit | c05746eac2e23522a355a794cedf697c95ee7cef (patch) | |
tree | 81b02da317d0c61baf9ef7d540c06e538609d82b /.dockerignore | |
parent | d900abe7e10f958765a0e817c4f3b2379b384ece (diff) | |
download | spack-c05746eac2e23522a355a794cedf697c95ee7cef.tar.gz spack-c05746eac2e23522a355a794cedf697c95ee7cef.tar.bz2 spack-c05746eac2e23522a355a794cedf697c95ee7cef.tar.xz spack-c05746eac2e23522a355a794cedf697c95ee7cef.zip |
llvm: use LIBCXX_ENABLE_STATIC_ABI_LIBRARY=ON (#27448)
The previous workaround of using CMAKE_INSTALL_RPATH=ON was used to
avoid CMake trying to write an RPATH into the linker script libcxx.so,
which is nonsensical. See commit f86ed1e.
However, CMAKE_INSTALL_RPATH=ON seems to disable the build RPATH, which
breaks LLVM during the build when it has to locate its build-time shared
libraries (e.g. libLLVM.so). That required yet another workaround, where
some shared libraries were installed "by hand", so that they were picked
up from the install libdir. See commit 8a81229.
This was a dirty workaround, and also makes it impossible to use ninja,
since we explicitly invoked make.
This commit removes the two old workaround, and sets
LIBCXX_ENABLE_STATIC_ABI_LIBRARY=ON, so that libc++abi.a is linked into
libc++.so, which makes it enough to link with -lc++ or invoke clang++
with -stdlib=libc++, so that our install succeeds and linking LLVM's c++
standard lib is still easy.
Diffstat (limited to '.dockerignore')
0 files changed, 0 insertions, 0 deletions