summaryrefslogtreecommitdiff
path: root/.flake8
diff options
context:
space:
mode:
authorscheibelp <scheibel1@llnl.gov>2018-06-26 16:14:05 -0700
committerTodd Gamblin <tgamblin@llnl.gov>2018-06-26 16:14:05 -0700
commit3560f6dbe9823c4b36783dfb8244d01672074760 (patch)
treeed5843c06d12c8c3fba8e26ae3e0fb04758c22a5 /.flake8
parent1276ce0585187d56d3f4fe3da9ca0753d04441fa (diff)
downloadspack-3560f6dbe9823c4b36783dfb8244d01672074760.tar.gz
spack-3560f6dbe9823c4b36783dfb8244d01672074760.tar.bz2
spack-3560f6dbe9823c4b36783dfb8244d01672074760.tar.xz
spack-3560f6dbe9823c4b36783dfb8244d01672074760.zip
views: packages can customize how they're added to views (#7152)
Functional updates: - `python` now creates a copy of the `python` binaries when it is added to a view - Python extensions (packages which subclass `PythonPackage`) rewrite their shebang lines to refer to python in the view - Python packages in the same namespace will not generate conflicts if both have `...lib/site-packages/namespace-example/__init__.py` - These `__init__` files will also remain when removing any package in the namespace until the last package in the namespace is removed Generally (Updated 2/16): - Any package can define `add_files_to_view` to customize how it is added to a view (and at the moment custom definitions are included for `python` and `PythonPackage`) - Likewise any package can define `remove_files_from_view` to customize which files are removed (e.g. you don't always want to remove the namespace `__init__`) - Any package can define `view_file_conflicts` to customize what it considers a merge conflict - Global activations are handled like views (where the view root is the spec prefix of the extendee) - Benefit: filesystem-management aspects of activating extensions are now placed in views (e.g. now one can hardlink a global activation) - Benefit: overriding `Package.activate` is more straightforward (see `Python.activate`) - Complication: extension packages which have special-purpose logic *only* when activated outside of the extendee prefix must check for this in their `add_files_to_view` method (see `PythonPackage`) - `LinkTree` is refactored to have separate methods for copying a directory structure and for copying files (since it was found that generally packages may want to alter how files are copied but still wanted to copy directories in the same way) TODOs (updated 2/20): - [x] additional testing (there is some unit testing added at this point but more would be useful) - [x] refactor or reorganize `LinkTree` methods: currently there is a separate set of methods for replicating just the directory structure without the files, and a set for replicating everything - [x] Right now external views (i.e. those not used for global activations) call `view.add_extension`, but global activations do not to avoid some extra work that goes into maintaining external views. I'm not sure if addressing that needs to be done here but I'd like to clarify it in the comments (UPDATE: for now I have added a TODO and in my opinion this can be merged now and the refactor handled later) - [x] Several method descriptions (e.g. for `Package.activate`) are out of date and reference a distinction between global activations and views, they need to be updated - [x] Update aspell package activations
Diffstat (limited to '.flake8')
0 files changed, 0 insertions, 0 deletions