summaryrefslogtreecommitdiff
path: root/.flake8_packages
diff options
context:
space:
mode:
authorAdam J. Stewart <ajstewart426@gmail.com>2018-08-20 16:42:28 -0500
committerscheibelp <scheibel1@llnl.gov>2018-08-20 17:42:28 -0400
commit2e8a820afd683f7f68b0ce04853b3c3fefe9ed2a (patch)
treedf70e44e1fd83bc7063ece262838d16ad53e59dc /.flake8_packages
parent2cd3e3fa76c20b0cde6c7fb60ad1a430e5a6d9f3 (diff)
downloadspack-2e8a820afd683f7f68b0ce04853b3c3fefe9ed2a.tar.gz
spack-2e8a820afd683f7f68b0ce04853b3c3fefe9ed2a.tar.bz2
spack-2e8a820afd683f7f68b0ce04853b3c3fefe9ed2a.tar.xz
spack-2e8a820afd683f7f68b0ce04853b3c3fefe9ed2a.zip
Even better Makefile target parsing (#8819)
#8223 replaced regex-based makefile target parsing with an invocation of "make -q". #8818 discovered that "make -q" can result in an error for some packages. Also, the "make -q" strategy relied on interpreting the error code, which only worked for GNU Make and not BSD Make (which was deemed acceptable at the time). As an added bonus, this implementation ignores the exit code and instead parses STDERR for any indications that the target does not exist; this works for both GNU Make and BSD Make. #8223 also updated ninja target detection to use "ninja -t targets". This does not change that behavior but makes it more-explicit with "ninja -t targets all" This also adds tests for detection of "make" and "ninja" targets.
Diffstat (limited to '.flake8_packages')
0 files changed, 0 insertions, 0 deletions