diff options
author | Severin Strobl <severin.strobl@dlr.de> | 2021-04-07 11:55:24 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-04-07 11:55:24 +0200 |
commit | b7d72e26bb5dae2517d1b91030269144833a6e94 (patch) | |
tree | f5c78f53b672adc66a04d524e3efe57ed710bd2c | |
parent | 58edc361be0aec47bfed24ef310ffa808153c74c (diff) | |
download | spack-b7d72e26bb5dae2517d1b91030269144833a6e94.tar.gz spack-b7d72e26bb5dae2517d1b91030269144833a6e94.tar.bz2 spack-b7d72e26bb5dae2517d1b91030269144833a6e94.tar.xz spack-b7d72e26bb5dae2517d1b91030269144833a6e94.zip |
otf2: patch for uninitialized variable (#22719)
As pointed out in https://github.com/STEllAR-GROUP/hpx/issues/5239,
there is an issues in OTF2 <=2.2 where a variable is not properly
initialized. As currently no release of OTF2 is available fixing this,
the patch should be applied.
-rw-r--r-- | var/spack/repos/builtin/packages/otf2/collective_callbacks.patch | 13 | ||||
-rw-r--r-- | var/spack/repos/builtin/packages/otf2/package.py | 4 |
2 files changed, 17 insertions, 0 deletions
diff --git a/var/spack/repos/builtin/packages/otf2/collective_callbacks.patch b/var/spack/repos/builtin/packages/otf2/collective_callbacks.patch new file mode 100644 index 0000000000..daa07d84cb --- /dev/null +++ b/var/spack/repos/builtin/packages/otf2/collective_callbacks.patch @@ -0,0 +1,13 @@ +diff --git a/src/otf2_archive_int.c b/src/otf2_archive_int.c +index db9b7a9..68f1694 100644 +--- a/src/otf2_archive_int.c ++++ b/src/otf2_archive_int.c +@@ -1083,7 +1083,7 @@ otf2_archive_set_collective_callbacks( OTF2_Archive* archive, + archive->global_comm_context = globalCommContext; + archive->local_comm_context = localCommContext; + +- OTF2_ErrorCode status; ++ OTF2_ErrorCode status = OTF2_SUCCESS; + + /* It is time to create the directories by the root rank. */ + if ( archive->file_mode == OTF2_FILEMODE_WRITE ) diff --git a/var/spack/repos/builtin/packages/otf2/package.py b/var/spack/repos/builtin/packages/otf2/package.py index c12c1fd352..78a384d792 100644 --- a/var/spack/repos/builtin/packages/otf2/package.py +++ b/var/spack/repos/builtin/packages/otf2/package.py @@ -24,6 +24,10 @@ class Otf2(AutotoolsPackage): version('1.3.1', sha256='c4605ace845d89fb1a19223137b92cc503b01e3db5eda8c9e0715d0cfcf2e4b9') version('1.2.1', sha256='1db9fb0789de4a9c3c96042495e4212a22cb581f734a1593813adaf84f2288e4') + # Fix missing initialization of variable resulting in issues when used by + # APEX/HPX: https://github.com/STEllAR-GROUP/hpx/issues/5239 + patch('collective_callbacks.patch', when='@2.1:2.2') + def configure_args(self): return [ '--enable-shared', |