diff options
| author | Massimiliano Culpo <massimiliano.culpo@gmail.com> | 2022-05-04 07:43:29 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-04 07:43:29 +0200 |
| commit | 5c7d6c6e100bd5ac331e8679e810de08516228bf (patch) | |
| tree | e5f2a6bef05e34c1f010321a0cc4b83a6cfa6022 | |
| parent | 96f9a1d88b2c25a37f97dcf96e596a7706cc4a2d (diff) | |
| download | spack-5c7d6c6e100bd5ac331e8679e810de08516228bf.tar.gz spack-5c7d6c6e100bd5ac331e8679e810de08516228bf.tar.bz2 spack-5c7d6c6e100bd5ac331e8679e810de08516228bf.tar.xz spack-5c7d6c6e100bd5ac331e8679e810de08516228bf.zip | |
Remove deprecated "--run-tests" option of "spack install" (#30461)
| -rw-r--r-- | lib/spack/spack/cmd/install.py | 9 | ||||
| -rw-r--r-- | lib/spack/spack/test/cmd/install.py | 1 | ||||
| -rwxr-xr-x | share/spack/spack-completion.bash | 2 |
3 files changed, 2 insertions, 10 deletions
diff --git a/lib/spack/spack/cmd/install.py b/lib/spack/spack/cmd/install.py index e95f118956..974f10f047 100644 --- a/lib/spack/spack/cmd/install.py +++ b/lib/spack/spack/cmd/install.py @@ -159,10 +159,6 @@ installation for top-level packages (but skip tests for dependencies). if 'all' is chosen, run package tests during installation for all packages. If neither are chosen, don't run tests for any packages.""" ) - testing.add_argument( - '--run-tests', action='store_true', - help='run package tests during installation (same as --test=all)' - ) subparser.add_argument( '--log-format', default=None, @@ -316,11 +312,8 @@ environment variables: if args.log_file: reporter.filename = args.log_file - if args.run_tests: - tty.warn("Deprecated option: --run-tests: use --test=all instead") - def get_tests(specs): - if args.test == 'all' or args.run_tests: + if args.test == 'all': return True elif args.test == 'root': return [spec.name for spec in specs] diff --git a/lib/spack/spack/test/cmd/install.py b/lib/spack/spack/test/cmd/install.py index 496656e69a..fea3431a73 100644 --- a/lib/spack/spack/test/cmd/install.py +++ b/lib/spack/spack/test/cmd/install.py @@ -87,7 +87,6 @@ def test_install_runtests_all(monkeypatch, mock_packages, install_mockery): monkeypatch.setattr(spack.package.PackageBase, 'unit_test_check', check) install('--test=all', 'a') - install('--run-tests', 'a') def test_install_package_already_installed( diff --git a/share/spack/spack-completion.bash b/share/spack/spack-completion.bash index 59902d2fd1..8f529a140c 100755 --- a/share/spack/spack-completion.bash +++ b/share/spack/spack-completion.bash @@ -1170,7 +1170,7 @@ _spack_info() { _spack_install() { if $list_options then - SPACK_COMPREPLY="-h --help --only -u --until -j --jobs --overwrite --fail-fast --keep-prefix --keep-stage --dont-restage --use-cache --no-cache --cache-only --monitor --monitor-save-local --monitor-tags --monitor-keep-going --monitor-host --monitor-prefix --include-build-deps --no-check-signature --require-full-hash-match --show-log-on-error --source -n --no-checksum --deprecated -v --verbose --fake --only-concrete --no-add -f --file --clean --dirty --test --run-tests --log-format --log-file --help-cdash --cdash-upload-url --cdash-build --cdash-site --cdash-track --cdash-buildstamp -y --yes-to-all -U --fresh --reuse" + SPACK_COMPREPLY="-h --help --only -u --until -j --jobs --overwrite --fail-fast --keep-prefix --keep-stage --dont-restage --use-cache --no-cache --cache-only --monitor --monitor-save-local --monitor-tags --monitor-keep-going --monitor-host --monitor-prefix --include-build-deps --no-check-signature --require-full-hash-match --show-log-on-error --source -n --no-checksum --deprecated -v --verbose --fake --only-concrete --no-add -f --file --clean --dirty --test --log-format --log-file --help-cdash --cdash-upload-url --cdash-build --cdash-site --cdash-track --cdash-buildstamp -y --yes-to-all -U --fresh --reuse" else _all_packages fi |