singularity: update version to 3.3.0 (#12295)

* add checksum for singularity release 3.3.0

* update singularity doc URL

URL at the lbl.gov domain has message saying:
"This website is going away soon! Update your bookmarks!"

* add note about build log file for post-install step

* provide links to both 2.x and 3.x security docs

* remove whitespace.  Passing flake8 confirmed locally this time :)

* add TODO comment for fakeroot support

1 files changed, 8 insertions, 2 deletions

diff --git a/var/spack/repos/builtin/packages/singularity/package.py b/var/spack/repos/builtin/packages/singularity/package.py
index 95b46c5876..a368d5bf9a 100644
--- a/var/spack/repos/builtin/packages/singularity/package.py
+++ b/var/spack/repos/builtin/packages/singularity/package.py
@@ -17,7 +17,7 @@ class Singularity(MakefilePackage):
        which has a different install base (Autotools).
 
        Needs post-install chmod/chown steps to enable full functionality.
-       See package definition for details.
+       See package definition or `spack-build-out.txt` build log for details.
     '''
 
     homepage = "https://www.sylabs.io/singularity/"
@@ -25,6 +25,7 @@ class Singularity(MakefilePackage):
     git      = "https://github.com/sylabs/singularity.git"
 
     version('develop', branch='master')
+    version('3.3.0', sha256='070530a472e7e78492f1f142c8d4b77c64de4626c4973b0589f0d18e1fcf5b4f')
     version('3.2.1', sha256='d4388fb5f7e0083f0c344354c9ad3b5b823e2f3f27980e56efa7785140c9b616')
     version('3.1.1', '158f58a79db5337e1d655ee0159b641e42ea7435')
 
@@ -34,6 +35,9 @@ class Singularity(MakefilePackage):
     depends_on('squashfs', type='run')
     depends_on('git', when='@develop')  # mconfig uses it for version info
 
+    # TODO: add dependency to support fakeroot option, for example:
+    # depends_on('shadow-uidmap', type='run', when='@3.3:')
+
     # Go has novel ideas about how projects should be organized.
     # We'll point GOPATH at the stage dir, and move the unpacked src
     # tree into the proper subdir in our overridden do_stage below.
@@ -136,7 +140,9 @@ class Singularity(MakefilePackage):
         tty.warn("""
         For full functionality, you'll need to chown and chmod some files
         after installing the package.  This has security implications.
-        See: https://singularity.lbl.gov/docs-security for details.
+        For details, see:
+        https://sylabs.io/guides/2.6/admin-guide/security.html
+        https://sylabs.io/guides/3.2/admin-guide/admin_quickstart.html#singularity-security
 
         We've installed a script that will make the necessary changes;
         read through it and then execute it as root (e.g. via sudo).