summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Scheibel <scheibel1@llnl.gov>2019-01-24 21:29:21 -0600
committerGitHub <noreply@github.com>2019-01-24 21:29:21 -0600
commit5abf29c971913d05808173ba46c2d8bce4ddc0c3 (patch)
tree7cb4f7fc0e3246ef1e695bcba9a80a1f830a1d8e
parent98e0b5b0db787ada2ae83e6b08818d1b1a8eab05 (diff)
downloadspack-5abf29c971913d05808173ba46c2d8bce4ddc0c3.tar.gz
spack-5abf29c971913d05808173ba46c2d8bce4ddc0c3.tar.bz2
spack-5abf29c971913d05808173ba46c2d8bce4ddc0c3.tar.xz
spack-5abf29c971913d05808173ba46c2d8bce4ddc0c3.zip
Environments: fix bug for install of external packages (#10437)
"spack install" will install all packages added to the current environment. When this included external packages, the environment update would fail because it would attempt to copy log files that were only generated if Spack handled the install itself. This skips that step for external packages.
-rw-r--r--lib/spack/spack/environment.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/spack/spack/environment.py b/lib/spack/spack/environment.py
index 49a71d37b4..57a7f8c454 100644
--- a/lib/spack/spack/environment.py
+++ b/lib/spack/spack/environment.py
@@ -663,6 +663,7 @@ class Environment(object):
with fs.working_dir(self.path):
spec.package.do_install(**kwargs)
+ if not spec.external:
# Link the resulting log file into logs dir
build_log_link = os.path.join(
log_path, '%s-%s.log' % (spec.name, spec.dag_hash(7)))