diff options
| author | Michael Kuhn <michael@ikkoku.de> | 2019-03-11 21:12:28 +0100 |
|---|---|---|
| committer | Peter Scheibel <scheibel1@llnl.gov> | 2019-03-11 15:12:28 -0500 |
| commit | 9425075a23234ec52c263e549cede9466df0e362 (patch) | |
| tree | b2ced2a46d49a9c4dfbcbbfb62e788aad005741d | |
| parent | 43525d344568e1a52c88451fbd7e10f59e4e6c90 (diff) | |
| download | spack-9425075a23234ec52c263e549cede9466df0e362.tar.gz spack-9425075a23234ec52c263e549cede9466df0e362.tar.bz2 spack-9425075a23234ec52c263e549cede9466df0e362.tar.xz spack-9425075a23234ec52c263e549cede9466df0e362.zip | |
flex: Apply 2.6.4 patch regardless of gcc version (#10841)
It seems that this is actually a glibc problem and while 2.6.4 builds
without the patch on newer versions of gcc (@8:), it still sometimes
segfaults (as observed during the doxygen build).
| -rw-r--r-- | var/spack/repos/builtin/packages/flex/package.py | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/var/spack/repos/builtin/packages/flex/package.py b/var/spack/repos/builtin/packages/flex/package.py index 65458e44f9..6c7891eaf2 100644 --- a/var/spack/repos/builtin/packages/flex/package.py +++ b/var/spack/repos/builtin/packages/flex/package.py @@ -28,25 +28,23 @@ class Flex(AutotoolsPackage): depends_on('gettext@0.19:', type='build') depends_on('help2man', type='build') - # Older tarballs don't come with a configure script + # Older tarballs don't come with a configure script and the patch for + # 2.6.4 touches configure depends_on('m4', type='build') - depends_on('autoconf', type='build', when='@:2.6.0') - depends_on('autoconf', type='build', when='@2.6.4 %gcc@7') - depends_on('automake', type='build', when='@:2.6.0') - depends_on('automake', type='build', when='@2.6.4 %gcc@7') - depends_on('libtool', type='build', when='@:2.6.0') - depends_on('libtool', type='build', when='@2.6.4 %gcc@7') + depends_on('autoconf', type='build', when='@:2.6.0,2.6.4') + depends_on('automake', type='build', when='@:2.6.0,2.6.4') + depends_on('libtool', type='build', when='@:2.6.0,2.6.4') - # 2.6.4 fails to compile with gcc@7, see: + # 2.6.4 fails to compile with newer versions of gcc/glibc, see: # - https://github.com/spack/spack/issues/8152 # - https://github.com/spack/spack/issues/6942 # - https://github.com/westes/flex/issues/241 - patch('https://github.com/westes/flex/commit/24fd0551333e7eded87b64dd36062da3df2f6380.patch', sha256='09c22e5c6fef327d3e48eb23f0d610dcd3a35ab9207f12e0f875701c677978d3', when='@2.6.4 %gcc@7') + patch('https://github.com/westes/flex/commit/24fd0551333e7eded87b64dd36062da3df2f6380.patch', sha256='09c22e5c6fef327d3e48eb23f0d610dcd3a35ab9207f12e0f875701c677978d3', when='@2.6.4') @property def force_autoreconf(self): # The patch for 2.6.4 touches configure - return self.spec.satisfies('@2.6.4 %gcc@7') + return self.spec.satisfies('@2.6.4') def url_for_version(self, version): url = "https://github.com/westes/flex" |