diff options
author | Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com> | 2024-06-21 03:24:46 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-06-21 12:24:46 +0200 |
commit | 3848c41494b683574d9d5cc843769ed53698843c (patch) | |
tree | 0547410c97234eae1e2652d58d80293c8e020d1b | |
parent | da720cafd8a2e73742713531f1dc7bed111c3392 (diff) | |
download | spack-3848c41494b683574d9d5cc843769ed53698843c.tar.gz spack-3848c41494b683574d9d5cc843769ed53698843c.tar.bz2 spack-3848c41494b683574d9d5cc843769ed53698843c.tar.xz spack-3848c41494b683574d9d5cc843769ed53698843c.zip |
Bugfix: test_is_externally_detectable needs to use mockpackages (#44795)
-rw-r--r-- | lib/spack/spack/test/cmd/info.py | 4 | ||||
-rw-r--r-- | var/spack/repos/builtin.mock/packages/find-externals1/package.py | 4 |
2 files changed, 6 insertions, 2 deletions
diff --git a/lib/spack/spack/test/cmd/info.py b/lib/spack/spack/test/cmd/info.py index e3d7b383a5..a0ea57b03e 100644 --- a/lib/spack/spack/test/cmd/info.py +++ b/lib/spack/spack/test/cmd/info.py @@ -57,9 +57,9 @@ def test_info_noversion(mock_packages, print_buffer): @pytest.mark.parametrize( - "pkg_query,expected", [("zlib", "False"), ("gcc", "True (version, variants)")] + "pkg_query,expected", [("zlib", "False"), ("find-externals1", "True (version)")] ) -def test_is_externally_detectable(pkg_query, expected, parser, print_buffer): +def test_is_externally_detectable(mock_packages, pkg_query, expected, parser, print_buffer): args = parser.parse_args(["--detectable", pkg_query]) spack.cmd.info.info(parser, args) diff --git a/var/spack/repos/builtin.mock/packages/find-externals1/package.py b/var/spack/repos/builtin.mock/packages/find-externals1/package.py index 2a82fad9b5..07d16a8f22 100644 --- a/var/spack/repos/builtin.mock/packages/find-externals1/package.py +++ b/var/spack/repos/builtin.mock/packages/find-externals1/package.py @@ -17,6 +17,10 @@ class FindExternals1(AutotoolsPackage): version("1.0", md5="abcdef1234567890abcdef1234567890") @classmethod + def determine_version(cls, exe): + return "1.0" + + @classmethod def determine_spec_details(cls, prefix, exes_in_prefix): exe_to_path = dict((os.path.basename(p), p) for p in exes_in_prefix) exes = [x for x in exe_to_path.keys() if "find-externals1-exe" in x] |