diff options
| author | Sreenivasa Murthy Kolam <sreenivasamurthy.kolam@amd.com> | 2024-07-26 19:14:06 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-26 06:44:06 -0700 |
| commit | f99a5ef2e7afd001d3ee6ca1bbb662c2f61903b8 (patch) | |
| tree | b24329cc70c29e535a19cb7d8cd16ce0cffdc2eb | |
| parent | 690bcf5d47259577da1924873117d453773544da (diff) | |
| download | spack-f99a5ef2e7afd001d3ee6ca1bbb662c2f61903b8.tar.gz spack-f99a5ef2e7afd001d3ee6ca1bbb662c2f61903b8.tar.bz2 spack-f99a5ef2e7afd001d3ee6ca1bbb662c2f61903b8.tar.xz spack-f99a5ef2e7afd001d3ee6ca1bbb662c2f61903b8.zip | |
Fix build failure when kokkos +rocm is enabled. (#44459)
* fix kokkos +rocm build failure
* address review comments
* address review comments . revert the previous changes
* address review comments. Add rocthrust for 4.3 version onwards
| -rw-r--r-- | var/spack/repos/builtin/packages/kokkos/package.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/var/spack/repos/builtin/packages/kokkos/package.py b/var/spack/repos/builtin/packages/kokkos/package.py index f6fa1f6cb1..18ef8b9f01 100644 --- a/var/spack/repos/builtin/packages/kokkos/package.py +++ b/var/spack/repos/builtin/packages/kokkos/package.py @@ -202,6 +202,7 @@ class Kokkos(CMakePackage, CudaPackage, ROCmPackage): variant(dev, default=dflt, description=desc) conflicts("+cuda", when="+rocm", msg="CUDA and ROCm are not compatible in Kokkos.") depends_on("intel-oneapi-dpl", when="+sycl") + depends_on("rocthrust", when="@4.3: +rocm") for opt, (dflt, desc) in options_variants.items(): variant(opt, default=dflt, description=desc, when=("+cuda" if "cuda" in opt else None)) @@ -354,6 +355,7 @@ class Kokkos(CMakePackage, CudaPackage, ROCmPackage): if "+rocm" in self.spec: options.append(self.define("CMAKE_CXX_COMPILER", self.spec["hip"].hipcc)) + options.append(self.define("Kokkos_ENABLE_ROCTHRUST", True)) elif "+wrapper" in self.spec: options.append( self.define("CMAKE_CXX_COMPILER", self.spec["kokkos-nvcc-wrapper"].kokkos_cxx) |