summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Olesen <Mark.Olesen@gmx.net>2017-06-27 12:34:52 +0100
committerAdam J. Stewart <ajstewart426@gmail.com>2017-06-27 06:34:52 -0500
commit051d15f7772b7b2add1c5dc638bc4f87b75a5eba (patch)
treed7eb6223fe54d26f732fa70b80647e6af2cbc809
parent351f0e2e16ebd52ef349d3538ebf485697883515 (diff)
downloadspack-051d15f7772b7b2add1c5dc638bc4f87b75a5eba.tar.gz
spack-051d15f7772b7b2add1c5dc638bc4f87b75a5eba.tar.bz2
spack-051d15f7772b7b2add1c5dc638bc4f87b75a5eba.tar.xz
spack-051d15f7772b7b2add1c5dc638bc4f87b75a5eba.zip
BUG: inconsistent -fPIC causes adios/mxml linkage problem (fix #4605) (#4606)
- Thanks to pointer from @adamjstewart - can avoid this either by avoiding an external mxml dependency, or by making certain that they both use consistent code generation. The adios package uses '-fPIC' for python linkage and this seems to require the same for mxml too. If the adios-internal version of mxml is used, it has the same flags for both.
-rw-r--r--var/spack/repos/builtin/packages/mxml/package.py8
1 files changed, 6 insertions, 2 deletions
diff --git a/var/spack/repos/builtin/packages/mxml/package.py b/var/spack/repos/builtin/packages/mxml/package.py
index c0ff5f6cd9..e8b87e52c1 100644
--- a/var/spack/repos/builtin/packages/mxml/package.py
+++ b/var/spack/repos/builtin/packages/mxml/package.py
@@ -48,5 +48,9 @@ class Mxml(AutotoolsPackage):
return 'https://github.com/michaelrsweet/mxml/releases/download/release-{0}/mxml-{0}.tar.gz'.format(version)
def configure_args(self):
- # Default is non-shared, but avoid any future surprises
- return ['--disable-shared']
+ return [
+ # ADIOS build with -fPIC, so we need it too (avoid linkage issue)
+ 'CFLAGS=-fPIC',
+ # Default is non-shared, but avoid any future surprises
+ '--disable-shared',
+ ]