diff options
| author | Greg Sjaardema <gsjaardema@gmail.com> | 2021-05-03 15:21:07 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-03 14:21:07 -0700 |
| commit | 5a747b91838d0bbc6ff38359686e3c109cd7fee9 (patch) | |
| tree | ad7e9b53968b2b6f78a90087487d4c35a8e8f972 | |
| parent | 6ded2c38d187a3b26faec7f750ce6301bbd19f2e (diff) | |
| download | spack-5a747b91838d0bbc6ff38359686e3c109cd7fee9.tar.gz spack-5a747b91838d0bbc6ff38359686e3c109cd7fee9.tar.bz2 spack-5a747b91838d0bbc6ff38359686e3c109cd7fee9.tar.xz spack-5a747b91838d0bbc6ff38359686e3c109cd7fee9.zip | |
Version update, new variant (#23409)
* Added checksum for recently released 4.8.0
* Added `enable-fsync` variant. The `fsync` flag was added to the configuration as of version 4.1.0 and later. Originally, it defaulted to `on`, but at version 4.3.0 and later, it was changed to default to `off` and a `enable-fsync` configuration flag was added to enable it.
The spack package has the `--enable-fsync` specified with no way to disable for all builds of netcdf-c 4.1.0 and later. This can cause horrendously slow I/O for certain use cases (e.g. 7 seconds with no-fsync versus 2300 seconds with fsync enabled). With the new variant, the default build behavior matches the default of non-spack netCDF.
| -rw-r--r-- | var/spack/repos/builtin/packages/netcdf-c/package.py | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/var/spack/repos/builtin/packages/netcdf-c/package.py b/var/spack/repos/builtin/packages/netcdf-c/package.py index 16d177890c..49c68122b2 100644 --- a/var/spack/repos/builtin/packages/netcdf-c/package.py +++ b/var/spack/repos/builtin/packages/netcdf-c/package.py @@ -26,6 +26,7 @@ class NetcdfC(AutotoolsPackage): maintainers = ['skosukhin', 'WardF'] version('master', branch='master') + version('4.8.0', sha256='679635119a58165c79bb9736f7603e2c19792dd848f19195bf6881492246d6d5') version('4.7.4', sha256='0e476f00aeed95af8771ff2727b7a15b2de353fb7bb3074a0d340b55c2bd4ea8') version('4.7.3', sha256='8e8c9f4ee15531debcf83788594744bd6553b8489c06a43485a15c93b4e0448b') version('4.7.2', sha256='b751cc1f314ac8357df2e0a1bacf35a624df26fe90981d3ad3fa85a5bbd8989a') @@ -66,6 +67,7 @@ class NetcdfC(AutotoolsPackage): variant('shared', default=True, description='Enable shared library') variant('dap', default=False, description='Enable DAP support') variant('jna', default=False, description='Enable JNA support') + variant('enable-fsync', default=False, description='Enable fsync support') # It's unclear if cdmremote can be enabled if '--enable-netcdf-4' is passed # to the configure script. Since netcdf-4 support is mandatory we comment @@ -187,6 +189,12 @@ class NetcdfC(AutotoolsPackage): if hdf5_hl.satisfies('~shared'): libs.append(hdf5_hl.libs.link_flags) + if '+enable-fsync' in self.spec: + # The flag was introduced in version 4.1.0. It was default + # `on` until 4.3.0 when it now defaults to `off`. + if self.spec.satisfies('@4.1:'): + config_args.append('--enable-fsync') + if '+parallel-netcdf' in self.spec: config_args.append('--enable-pnetcdf') pnetcdf = self.spec['parallel-netcdf'] |