summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMassimiliano Culpo <massimiliano.culpo@gmail.com>2018-08-22 16:32:25 +0200
committerAdam J. Stewart <ajstewart426@gmail.com>2018-08-22 09:32:25 -0500
commit85f84aabedd67192fa419cb94a380b1d2551f125 (patch)
tree9f6bd3a6d349f01705b52a0a57df7de88c63c05d
parent2f6a6a45a977cf766345e31a41daae0ff910a434 (diff)
downloadspack-85f84aabedd67192fa419cb94a380b1d2551f125.tar.gz
spack-85f84aabedd67192fa419cb94a380b1d2551f125.tar.bz2
spack-85f84aabedd67192fa419cb94a380b1d2551f125.tar.xz
spack-85f84aabedd67192fa419cb94a380b1d2551f125.zip
Added a new target message to comply with newer versions of GNU Make (#9068)
#fixes 9067 Unit tests were failing on a system with GNU Make v 4.1
-rw-r--r--lib/spack/spack/package.py2
-rw-r--r--lib/spack/spack/test/build_systems.py1
2 files changed, 3 insertions, 0 deletions
diff --git a/lib/spack/spack/package.py b/lib/spack/spack/package.py
index b333c7e0c2..742349aa62 100644
--- a/lib/spack/spack/package.py
+++ b/lib/spack/spack/package.py
@@ -1166,11 +1166,13 @@ class PackageBase(with_metaclass(PackageMeta, PackageViewMixin, object)):
#
# GNU Make:
# make: *** No rule to make target `test'. Stop.
+ # *** No rule to make target 'test'. Stop.
#
# BSD Make:
# make: don't know how to make test. Stop
missing_target_msgs = [
"No rule to make target `{0}'. Stop.",
+ "No rule to make target '{0}'. Stop.",
"don't know how to make {0}. Stop",
]
diff --git a/lib/spack/spack/test/build_systems.py b/lib/spack/spack/test/build_systems.py
index 8915b813cb..adf40ca316 100644
--- a/lib/spack/spack/test/build_systems.py
+++ b/lib/spack/spack/test/build_systems.py
@@ -59,6 +59,7 @@ def test_affirmative_make_check(directory, config, mock_packages):
'directory',
glob.iglob(os.path.join(DATA_PATH, 'make', 'negative', '*'))
)
+@pytest.mark.regression('9067')
def test_negative_make_check(directory, config, mock_packages):
"""Tests that Spack correctly ignores false positives in a Makefile."""