diff options
| author | George Hartzell <hartzell@alerce.com> | 2016-07-15 12:39:40 -0400 |
|---|---|---|
| committer | George Hartzell <hartzell@alerce.com> | 2016-07-15 12:39:40 -0400 |
| commit | 64b1bafd41ee5f9770e7082d45a95059a48a6aaa (patch) | |
| tree | dd2f5e3a828f91d96e65980c82f2f896862c6217 | |
| parent | a73d91a2e58a040d488bec1368212d93e058ed4d (diff) | |
| download | spack-64b1bafd41ee5f9770e7082d45a95059a48a6aaa.tar.gz spack-64b1bafd41ee5f9770e7082d45a95059a48a6aaa.tar.bz2 spack-64b1bafd41ee5f9770e7082d45a95059a48a6aaa.tar.xz spack-64b1bafd41ee5f9770e7082d45a95059a48a6aaa.zip | |
Make flake8 happy with .../jdk/package.py
My PR for adding a new jdk version failed its
travis run because of existing flake8 violoations.
This package cleans them up.
I'm not particularly pythonic, but most of the complaints were
obvious. HOWEVER, I'm not particularly confident about handling
long lines by taking an flake8 exception comment onto the end.
Feedback welcome...
| -rw-r--r-- | var/spack/repos/builtin/packages/jdk/package.py | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/var/spack/repos/builtin/packages/jdk/package.py b/var/spack/repos/builtin/packages/jdk/package.py index f0b871742c..593a6d8340 100644 --- a/var/spack/repos/builtin/packages/jdk/package.py +++ b/var/spack/repos/builtin/packages/jdk/package.py @@ -22,21 +22,20 @@ # License along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA ############################################################################## -#------------------------------------------------------------------------------ +# # Author: Justin Too <too1@llnl.gov> -#------------------------------------------------------------------------------ +# import distutils -from distutils import dir_util -from subprocess import call import spack from spack import * import llnl.util.tty as tty + class Jdk(Package): """The Java Development Kit (JDK) released by Oracle Corporation in the form of a binary product aimed at Java developers.""" - homepage = "http://www.oracle.com/technetwork/java/javase/downloads/index.html" + homepage = "http://www.oracle.com/technetwork/java/javase/downloads/index.html" # noqa: E501 version('8u66-linux-x64', '88f31f3d642c3287134297b8c10e61bf', url="http://download.oracle.com/otn-pub/java/jdk/8u66-b17/jdk-8u66-linux-x64.tar.gz") @@ -48,10 +47,10 @@ class Jdk(Package): # automate this process, we need to utilize these additional curl # commandline options. # - # See http://stackoverflow.com/questions/10268583/how-to-automate-download-and-installation-of-java-jdk-on-linux - curl_options=[ - '-j', # junk cookies - '-H', # specify required License Agreement cookie + # See http://stackoverflow.com/questions/10268583/how-to-automate-download-and-installation-of-java-jdk-on-linux # noqa: E501 + curl_options = [ + '-j', # junk cookies + '-H', # specify required License Agreement cookie 'Cookie: oraclelicense=accept-securebackup-cookie'] def do_fetch(self, mirror_only=False): @@ -67,6 +66,5 @@ class Jdk(Package): # Now perform the actual fetch super(Jdk, self).do_fetch(mirror_only) - def install(self, spec, prefix): distutils.dir_util.copy_tree(".", prefix) |