diff options
| author | David Wells <drwells@email.unc.edu> | 2018-09-03 10:43:00 -0400 |
|---|---|---|
| committer | Massimiliano Culpo <massimiliano.culpo@gmail.com> | 2018-09-03 16:43:00 +0200 |
| commit | 734d6306a261d209579ae473e5a004b65f55f6e2 (patch) | |
| tree | c496dd162274fcc89f17ac7c8499c94b1df2f2d1 | |
| parent | 940e35059ed3406b588f5bf4d3096c9a54d17fee (diff) | |
| download | spack-734d6306a261d209579ae473e5a004b65f55f6e2.tar.gz spack-734d6306a261d209579ae473e5a004b65f55f6e2.tar.bz2 spack-734d6306a261d209579ae473e5a004b65f55f6e2.tar.xz spack-734d6306a261d209579ae473e5a004b65f55f6e2.zip | |
Fix two dependencies with silo. (#9153)
1. I presently get errors of the sort
==> Error: KeyError: 'No spec with name mpi in silo@4.10.2%gcc@8.1.0+fortran+mpi
[...]
$HOME/spack/var/spack/repos/builtin/packages/silo/package.py:84, in configure_args:
81 'FCFLAGS={0}'.format(self.compiler.pic_flag)]
82
83 if '+mpi' in self.spec:
>> 84 config_args.append('CC=%s' % self.spec['mpi'].mpicc)
85 config_args.append('CXX=%s' % self.spec['mpi'].mpicxx)
86 config_args.append('FC=%s' % self.spec['mpi'].mpifc)
without the extra explicit MPI dependency.
2. Silo uses zlib, so we should explicitly depend on it.
| -rw-r--r-- | var/spack/repos/builtin/packages/silo/package.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/var/spack/repos/builtin/packages/silo/package.py b/var/spack/repos/builtin/packages/silo/package.py index d236a661f2..86c19e77f9 100644 --- a/var/spack/repos/builtin/packages/silo/package.py +++ b/var/spack/repos/builtin/packages/silo/package.py @@ -48,8 +48,10 @@ class Silo(AutotoolsPackage): description='Compile with MPI Compatibility') depends_on('hdf5~mpi', when='~mpi') + depends_on('mpi', when='+mpi') depends_on('hdf5+mpi', when='+mpi') depends_on('qt', when='+silex') + depends_on('zlib') patch('remove-mpiposix.patch', when='@4.8:4.10.2') |