diff options
| author | Satish Balay <balay@mcs.anl.gov> | 2018-10-31 14:49:04 -0500 |
|---|---|---|
| committer | Peter Scheibel <scheibel1@llnl.gov> | 2018-10-31 12:49:04 -0700 |
| commit | fb849a4b7f1361fe276e0761b6fdd73195ea1600 (patch) | |
| tree | df1417b1b649052558e7e2e4c8f4c0ae206babf3 | |
| parent | 939ce40032e339cc7311a370c3bbef1e68f7733b (diff) | |
| download | spack-fb849a4b7f1361fe276e0761b6fdd73195ea1600.tar.gz spack-fb849a4b7f1361fe276e0761b6fdd73195ea1600.tar.bz2 spack-fb849a4b7f1361fe276e0761b6fdd73195ea1600.tar.xz spack-fb849a4b7f1361fe276e0761b6fdd73195ea1600.zip | |
static_to_shared_library: separate options from option values (#9690)
The 'static_to_shared_library' function takes a compiler Executable,
which is intended to be invoked with a list of arguments; the
arguments must be separated from their values in the list, given
the way that 'Executable.__call__' invokes the underlying executable.
'static_to_shared_library' was not doing this, which this commit fixes.
| -rw-r--r-- | lib/spack/spack/build_environment.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/spack/spack/build_environment.py b/lib/spack/spack/build_environment.py index fa79683717..3476df89d9 100644 --- a/lib/spack/spack/build_environment.py +++ b/lib/spack/spack/build_environment.py @@ -497,16 +497,16 @@ def _static_to_shared_library(arch, compiler, static_lib, shared_lib=None, compiler_args = [ '-dynamiclib', - '-install_name {0}'.format(install_name), + '-install_name', '{0}'.format(install_name), '-Wl,-force_load,{0}'.format(static_lib) ] if compat_version: - compiler_args.append('-compatibility_version {0}'.format( - compat_version)) + compiler_args.extend(['-compatibility_version', '{0}'.format( + compat_version)]) if version: - compiler_args.append('-current_version {0}'.format(version)) + compiler_args.extend(['-current_version', '{0}'.format(version)]) if len(arguments) > 0: compiler_args.extend(arguments) |