diff options
| author | Seth R. Johnson <johnsonsr@ornl.gov> | 2022-02-15 00:50:22 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-02-15 05:50:22 +0000 |
| commit | 08cad7d0ee37041694ebcbadf095d8d4d23630f0 (patch) | |
| tree | af6d20548bd50a5f8f2e8cfa1a9e03700093153b | |
| parent | 9165e3fb86f892429f6144f18fe53b6c7693ba6e (diff) | |
| download | spack-08cad7d0ee37041694ebcbadf095d8d4d23630f0.tar.gz spack-08cad7d0ee37041694ebcbadf095d8d4d23630f0.tar.bz2 spack-08cad7d0ee37041694ebcbadf095d8d4d23630f0.tar.xz spack-08cad7d0ee37041694ebcbadf095d8d4d23630f0.zip | |
darwin: make sure MACOSX_DEPLOYMENT_TARGET has a minor component (#28926)
| -rw-r--r-- | lib/spack/spack/platforms/darwin.py | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/lib/spack/spack/platforms/darwin.py b/lib/spack/spack/platforms/darwin.py index b4b542cb98..23aa10d81b 100644 --- a/lib/spack/spack/platforms/darwin.py +++ b/lib/spack/spack/platforms/darwin.py @@ -60,4 +60,13 @@ class Darwin(Platform): """ os = self.operating_sys[pkg.spec.os] - env.set('MACOSX_DEPLOYMENT_TARGET', str(os.version)) + version = os.version + if len(version) == 1: + # Version has only one component: add a minor version to prevent + # potential errors with `ld`, + # which fails with `-macosx_version_min 11` + # but succeeds with `-macosx_version_min 11.0`. + # Most compilers seem to perform this translation automatically, + # but older GCC does not. + version = str(version) + '.0' + env.set('MACOSX_DEPLOYMENT_TARGET', str(version)) |