diff options
| author | Seth R. Johnson <johnsonsr@ornl.gov> | 2022-03-16 17:31:33 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-16 22:31:33 +0100 |
| commit | 4ef534b19babe55fa3f22b9356aaeda2cc1c4920 (patch) | |
| tree | 903fc7473c193f6ba25f1865c6bb39dcddd0bc57 | |
| parent | 73287df7c50746a88b0a3a5db6725856acea42f8 (diff) | |
| download | spack-4ef534b19babe55fa3f22b9356aaeda2cc1c4920.tar.gz spack-4ef534b19babe55fa3f22b9356aaeda2cc1c4920.tar.bz2 spack-4ef534b19babe55fa3f22b9356aaeda2cc1c4920.tar.xz spack-4ef534b19babe55fa3f22b9356aaeda2cc1c4920.zip | |
libiconv,lmod: improvements for static builds (#29493)
* libiconv: compile with pic even when static build
* lmod: require shared lua
It seems to be unable to detect lua-posix when using a static lua:
```
Error: The follow lua module(s) are missing: posix
```
| -rw-r--r-- | var/spack/repos/builtin/packages/libiconv/package.py | 1 | ||||
| -rw-r--r-- | var/spack/repos/builtin/packages/lmod/package.py | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/var/spack/repos/builtin/packages/libiconv/package.py b/var/spack/repos/builtin/packages/libiconv/package.py index c0cc56cc21..e90f8dcea0 100644 --- a/var/spack/repos/builtin/packages/libiconv/package.py +++ b/var/spack/repos/builtin/packages/libiconv/package.py @@ -31,6 +31,7 @@ class Libiconv(AutotoolsPackage, GNUMirrorPackage): args = ['--enable-extra-encodings'] args += self.enable_or_disable('libs') + args.append('--with-pic') # A hack to patch config.guess in the libcharset sub directory copy('./build-aux/config.guess', diff --git a/var/spack/repos/builtin/packages/lmod/package.py b/var/spack/repos/builtin/packages/lmod/package.py index 196789a5a5..89f1ed1ea1 100644 --- a/var/spack/repos/builtin/packages/lmod/package.py +++ b/var/spack/repos/builtin/packages/lmod/package.py @@ -45,7 +45,7 @@ class Lmod(AutotoolsPackage): version('6.4.1', sha256='a260b4e42269a80b517c066ba8484658362ea095e80767a2376bbe33d9b070a5') version('6.3.7', sha256='55ddb52cbdc0e2e389b3405229336df9aabfa582c874f5df2559ea264e2ee4ae') - depends_on('lua@5.1:') + depends_on('lua+shared@5.1:') depends_on('lua-luaposix', type=('build', 'run')) depends_on('lua-luafilesystem', type=('build', 'run')) depends_on('tcl', type=('build', 'link', 'run')) |