diff options
| author | Brian Van Essen <vanessen1@llnl.gov> | 2022-06-17 16:52:06 -0500 |
|---|---|---|
| committer | Massimiliano Culpo <massimiliano.culpo@gmail.com> | 2022-07-20 08:10:41 +0200 |
| commit | b3e9abc72a181642235104d4c2784ac95acdcb02 (patch) | |
| tree | 019eb6c985a1496be96b6f0577b93d1eec1e18c9 | |
| parent | 488a513109ffda96e9b334f84e2c1a177e79b088 (diff) | |
| download | spack-b3e9abc72a181642235104d4c2784ac95acdcb02.tar.gz spack-b3e9abc72a181642235104d4c2784ac95acdcb02.tar.bz2 spack-b3e9abc72a181642235104d4c2784ac95acdcb02.tar.xz spack-b3e9abc72a181642235104d4c2784ac95acdcb02.zip | |
Bugfix external find --all for libraries (#31186)
* Fixed a bug in the 'external find --all' command where the call failed
to find packages by both executable and library. The bug was that the
call `path.all_packages()` incorrectly turned the variable
`packages_to_check` into a generator rather than keeping it a list.
Thus the second call to `detection.by_library` had no work to do.
* Fixed the help message for the find external and compiler commands as
well as others that used the `scopes_metavar` field to define where
the results should be stored in configuration space. Specifically,
the fact that configuration could be added to the environment was not
mentioned in the help message.
| -rw-r--r-- | lib/spack/spack/cmd/external.py | 2 | ||||
| -rw-r--r-- | lib/spack/spack/config.py | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/spack/spack/cmd/external.py b/lib/spack/spack/cmd/external.py index 11f5092626..e9060d5d17 100644 --- a/lib/spack/spack/cmd/external.py +++ b/lib/spack/spack/cmd/external.py @@ -125,7 +125,7 @@ def external_find(args): # If the list of packages is empty, search for every possible package if not args.tags and not packages_to_check: - packages_to_check = spack.repo.path.all_packages() + packages_to_check = list(spack.repo.path.all_packages()) detected_packages = spack.detection.by_executable( packages_to_check, path_hints=args.path) diff --git a/lib/spack/spack/config.py b/lib/spack/spack/config.py index ce90ed231e..2eb603780a 100644 --- a/lib/spack/spack/config.py +++ b/lib/spack/spack/config.py @@ -110,7 +110,7 @@ config_defaults = { #: metavar to use for commands that accept scopes #: this is shorter and more readable than listing all choices -scopes_metavar = '{defaults,system,site,user}[/PLATFORM]' +scopes_metavar = '{defaults,system,site,user}[/PLATFORM] or env:ENVIRONMENT' #: Base name for the (internal) overrides scope. overrides_base_name = 'overrides-' |