summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTodd Gamblin <tgamblin@llnl.gov>2016-05-13 10:00:57 -0700
committerTodd Gamblin <tgamblin@llnl.gov>2016-05-13 10:00:57 -0700
commit6ee21727de207f7b6741379c488b89c1ce2aee4d (patch)
treec8a806eaa132c4e65e2d8019bd374ce47ee3521f
parent5e13bba068244db9a71c2b4fc1bc52b85fcb5225 (diff)
parent8db35ab9a282c2a609afc846abb76f4bd22b836e (diff)
downloadspack-6ee21727de207f7b6741379c488b89c1ce2aee4d.tar.gz
spack-6ee21727de207f7b6741379c488b89c1ce2aee4d.tar.bz2
spack-6ee21727de207f7b6741379c488b89c1ce2aee4d.tar.xz
spack-6ee21727de207f7b6741379c488b89c1ce2aee4d.zip
Merge pull request #949 from davydden/bugfix/openblas
openblas: use spack_cc/spack_f77 and add a note on compiler mixing
-rw-r--r--var/spack/repos/builtin/packages/openblas/package.py12
1 files changed, 7 insertions, 5 deletions
diff --git a/var/spack/repos/builtin/packages/openblas/package.py b/var/spack/repos/builtin/packages/openblas/package.py
index ebfec4bded..22e49daaa7 100644
--- a/var/spack/repos/builtin/packages/openblas/package.py
+++ b/var/spack/repos/builtin/packages/openblas/package.py
@@ -48,11 +48,13 @@ class Openblas(Package):
patch('make.patch')
def install(self, spec, prefix):
- # Openblas is picky about compilers. Configure fails with
- # FC=/abs/path/to/f77, whereas FC=f77 works fine.
- # To circumvent this, provide basename only:
- make_defs = ['CC=%s' % os.path.basename(spack_cc),
- 'FC=%s' % os.path.basename(spack_f77),
+ # Configure fails to pick up fortran from FC=/abs/path/to/f77, but
+ # works fine with FC=/abs/path/to/gfortran.
+ # When mixing compilers make sure that
+ # $SPACK_ROOT/lib/spack/env/<compiler> have symlinks with reasonable
+ # names and hack them inside lib/spack/spack/compilers/<compiler>.py
+ make_defs = ['CC=%s' % spack_cc,
+ 'FC=%s' % spack_f77,
'MAKE_NO_J=1']
make_targets = ['libs', 'netlib']