diff options
author | Elizabeth Fischer <rpf2116@columbia.edu> | 2016-10-06 12:08:15 -0400 |
---|---|---|
committer | Todd Gamblin <tgamblin@llnl.gov> | 2016-10-06 09:08:15 -0700 |
commit | 98f8f40896c71fbc73a35ced29fed49533df9e18 (patch) | |
tree | 71787db0edfff04ca6ec5bead46bf40ec9d4c34c /LICENSE | |
parent | 2ccb3d5531c5fefb0b4fffce2a17b8effd3f2af6 (diff) | |
download | spack-98f8f40896c71fbc73a35ced29fed49533df9e18.tar.gz spack-98f8f40896c71fbc73a35ced29fed49533df9e18.tar.bz2 spack-98f8f40896c71fbc73a35ced29fed49533df9e18.tar.xz spack-98f8f40896c71fbc73a35ced29fed49533df9e18.zip |
[Bug Fix (and docs too)] : Do not select @develop version by default (#1933)
* This fixes a bug in concretization. Before the recent change to the
algorithm, the intent was that the @develop version, although
"greater" than numberic versions, is never preferred BY DEFAULT over
numeric versions.
To test this... suppose you have a package with no `preferred=True` in
it, and nothing in `packages.yaml`, but with a `develop` version. For
the sake of this example, I've hacked my `python/package.py` to work
this way.
Without bugfix (WRONG: user should never get develop by default):
```
python@develop%clang@7.3.0-apple~tk~ucs4 arch=darwin-elcapitan-x86_64
...
```
With bugfix (RIGHT: largest numeric version selected):
```
python@3.5.2%clang@7.3.0-apple~tk~ucs4 arch=darwin-elcapitan-x86_64
...
```
* Documented version selection in concretization algo.
* Fix typos
* flake8
Diffstat (limited to 'LICENSE')
0 files changed, 0 insertions, 0 deletions