diff options
| author | Todd Gamblin <tgamblin@llnl.gov> | 2014-04-14 14:11:58 -0700 |
|---|---|---|
| committer | Todd Gamblin <tgamblin@llnl.gov> | 2014-04-14 14:11:58 -0700 |
| commit | 50f74c117e52ecd9bd2594ccbdc9caaffba19c01 (patch) | |
| tree | 5dffc77b8e997a9d7319f11db54c7b6278b8b501 /LICENSE | |
| parent | 9fa99030eb1958b5bf2e1693443556438f363c30 (diff) | |
| download | spack-50f74c117e52ecd9bd2594ccbdc9caaffba19c01.tar.gz spack-50f74c117e52ecd9bd2594ccbdc9caaffba19c01.tar.bz2 spack-50f74c117e52ecd9bd2594ccbdc9caaffba19c01.tar.xz spack-50f74c117e52ecd9bd2594ccbdc9caaffba19c01.zip | |
Fix for SPACK-22: Consistent dependency hashing.
The dependency hash wasn't being generated in a consistent way: when
read from .spec file in the install directory, the spec DAG was not
normalized, but when generated on install, it was. Thus the same
spec can have two possible hashes, which is obviously not good.
In this commit:
- Added a dep_hash function to spec, which should be used to get the
dependency hash in all cases. This function normalizes the spec
before generating the hash.
- removed sha1 functions from Spec and DependencyHash. The one on
Spec is not needed and is confusing (it hashed the whole spec, not
just hash the deps) and the one on DependencyHash wasn't guaranteed
to be safe because it can't normalize its parent spec before
hashing.
Hopefully this makes things consistent and easy.
Diffstat (limited to 'LICENSE')
0 files changed, 0 insertions, 0 deletions