summaryrefslogtreecommitdiff
path: root/NOTICE
diff options
context:
space:
mode:
authorMassimiliano Culpo <massimiliano.culpo@gmail.com>2022-02-17 08:50:50 +0100
committerGitHub <noreply@github.com>2022-02-17 08:50:50 +0100
commitfa132614e09204238d9a95cb61cfe3b852877bdc (patch)
tree1242f9568f35e1d1adf3db49a6d7a0413edb1153 /NOTICE
parenta0bd6c8817bbd2839c3fe1e41e627bfabf3c052f (diff)
downloadspack-fa132614e09204238d9a95cb61cfe3b852877bdc.tar.gz
spack-fa132614e09204238d9a95cb61cfe3b852877bdc.tar.bz2
spack-fa132614e09204238d9a95cb61cfe3b852877bdc.tar.xz
spack-fa132614e09204238d9a95cb61cfe3b852877bdc.zip
ASP-based solver: don't sort when defining variant possible values (#29013)
fixes #28260 Since we iterate over different variants from many packages, the variant values may have types which are not comparable, which causes errors at runtime. This is not a real issue though, since we don't need the facts to be ordered. Thus, to avoid needless sorting, the sorted function has been removed and a comment has been added to tip any developer that might need to inspect these clauses for debugging to add back sorting on the first two items only. It's kind of difficult to add a test for this, since the error depends on whether Python sorting algorithm ever needs to compare the third value of a tuple being ordered.
Diffstat (limited to 'NOTICE')
0 files changed, 0 insertions, 0 deletions