summaryrefslogtreecommitdiff
path: root/NOTICE
diff options
context:
space:
mode:
authorTodd Gamblin <gamblin2@llnl.gov>2022-05-25 20:12:24 -0700
committerGitHub <noreply@github.com>2022-05-26 03:12:24 +0000
commitd51f949768cb5b18d1838815026ead2bc13ac227 (patch)
tree6b925aa889caf36759dffec572bc9a9df49df83c /NOTICE
parent1b955e66c12a910ac15c650fca5438400da9e290 (diff)
downloadspack-d51f949768cb5b18d1838815026ead2bc13ac227.tar.gz
spack-d51f949768cb5b18d1838815026ead2bc13ac227.tar.bz2
spack-d51f949768cb5b18d1838815026ead2bc13ac227.tar.xz
spack-d51f949768cb5b18d1838815026ead2bc13ac227.zip
bugfix: do not compute `package_hash` for old concrete specs (#30861)
Old concrete specs were slipping through in `_assign_hash`, and `package_hash` was attempting to recompute a package hash when we could not know the package a time of concretization. Part of this was that the logic for `_assign_hash` was hard to understand -- it was called twice from `_finalize_concretization` and had special cases for both args it was called with. It's much easier to understand the logic here if we just inline it. - [x] Get rid of `_assign_hash` and just integrate it with `_finalize_concretization` - [x] Don't call `_package_hash` at all for already-concrete specs. - [x] Add regression test.
Diffstat (limited to 'NOTICE')
0 files changed, 0 insertions, 0 deletions