diff options
author | Harmen Stoppels <me@harmenstoppels.nl> | 2023-12-19 23:33:16 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-12-19 23:33:16 +0100 |
commit | ec2729706b235f96fe481bf6333fbcc7732e28c1 (patch) | |
tree | 06a5d78fc9846898bb777eeab5d231b1947453b9 /README.md | |
parent | 494d3f9002454eba8da7f07e272937c8398172f6 (diff) | |
download | spack-ec2729706b235f96fe481bf6333fbcc7732e28c1.tar.gz spack-ec2729706b235f96fe481bf6333fbcc7732e28c1.tar.bz2 spack-ec2729706b235f96fe481bf6333fbcc7732e28c1.tar.xz spack-ec2729706b235f96fe481bf6333fbcc7732e28c1.zip |
environment_modifications_for_specs: do not mutate spec.prefix (#41737)
Sometimes env variables computed in `setup_run_environment` depend on tests
w.r.t. files in `spec.prefix`, but Spack temporarily projects `spec.prefix` to
the view.
This is problematic for two reasons:
1. Some packages iterate over `<prefix>/bin`: they expect only the current
package's executables, but find all linked in the view, leading to false
positives.
2. Some packages test for `os.path.islink(...)`, which is always true in a view
`gcc` is an example that does both.
This PR lets Spack compute the environment modifications using the original
prefix, and projects to the view afterwards
Diffstat (limited to 'README.md')
0 files changed, 0 insertions, 0 deletions